Backend: SkyHanniKeyBind Implementation#5503
Open
DavidArthurCole wants to merge 2 commits intohannibal002:betafrom
Open
Backend: SkyHanniKeyBind Implementation#5503DavidArthurCole wants to merge 2 commits intohannibal002:betafrom
DavidArthurCole wants to merge 2 commits intohannibal002:betafrom
Conversation
github-actions
bot
added
the
Backend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Structural implementation for hooking selective config options into the vanilla ui screen.
Because our config has so so so so many options, I figured this should probably be intentional rather than automatic, and went with an approach similar to RenderDisplayHelper. The feature class for the keybind can create it in an
init { }block at runtime, and define when it should appear, category, etc.Changelog Technical Details