Backend: Add VectorUtils, deprecate LorenzVec#5512
Open
lunaynx wants to merge 8 commits intohannibal002:betafrom
Open
Backend: Add VectorUtils, deprecate LorenzVec#5512lunaynx wants to merge 8 commits intohannibal002:betafrom
lunaynx wants to merge 8 commits intohannibal002:betafrom
Conversation
github-actions
bot
added
the
Backend
0 Detekt Failures |
github-actions
bot
added
the
Fails Multi-Version
Contributor
Author
|
I should probably pull in Edit: Done |
github-actions
bot
removed
the
Fails Multi-Version
1 Detekt Failure
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Precursor to #5493. Adds a new
VectorUtilsclass and deprecatesLorenzVec, but changes not much else (besides introducing hundreds of new deprecation warnings).The idea is to eventually fully move away from
LorenzVec, and use Minecraft's nativeVec3class and the extension functions inVectorUtils.Changelog Technical Details
VectorUtilsclass forVec3extensions and markedLorenzVecas deprecated. - LunaVec3ArgumentTypeand removedLorenzVecArgumentType. - Luna