Backend: Trigger Detekt from Build#5514
Open
DavidArthurCole wants to merge 5 commits intohannibal002:betafrom
Open
Backend: Trigger Detekt from Build#5514DavidArthurCole wants to merge 5 commits intohannibal002:betafrom
DavidArthurCole wants to merge 5 commits intohannibal002:betafrom
Conversation
github-actions
bot
added
the
Backend
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
Author
|
This is as good as I can get it, for now. The main goal was to have detekt re-use the build cache, which it now does; Unfortunately, the process of |
Contributor
Author
|
And in the case that git does some bull shittery to that PR after I rewind my beta branch: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
See conversation here:
https://discord.com/channels/997079228510117908/1250434494473834597/1488246359999123678
This makes the detekt CI run(s) trigger from the
buildstep of the workflow, rather than triggering onpush- this lets us "cache" the build output so that detekt doesn't entirely re-build the code from scratch, when it doesn't need to.Changelog Technical Details