Improvement: Hoe Level Displays

[NotRoboo]

What'

Changes the static "Hoe Levels" HUD title to adapt to which tool type user is using.

• Added "Axe Levels" in addition to "Hoe Levels"

If want any changes let me know/if there is better way i did this in 2min directly in github

Images

Changelog Improvements

• Improved Tool Level Display (formerly Hoe Levels Display) now adapts to the type of tool currently being used. - Roboo

[lunaynx]

Hypixel still calls the Cactus Knife a hoe, even though it has a sword item model. We don't distinguish between Chopper, Cutter, and Dicer either (nor do I think we should).

Also, small nitpick, but we can probably change "Farming Tool" to just "Tool" (not that it should ever realistically show up anyway).

May require adding imports to compile.

Suggested change

	val cleanName = heldItem.hoverName.string.removeColor()
	val title = when {
	cleanName.contains("Knife") -> "§6Knife Level"
	cleanName.contains("Chopper") || cleanName.contains("Dicer") -> "§6Axe Level"
	cleanName.contains("Hoe") || cleanName.contains("Cutter") -> "§6Hoe Level"
	else -> "§6Farming Tool Level"
	}
	val type = when (heldItem.getItemCategoryOrNull()) {
	ItemCategory.HOE -> "Hoe"
	ItemCategory.AXE -> "Axe"
	else -> "Tool"
	}
	val title = "§6$type Level"

[lunaynx]

Other references to "Hoe Levels" in the code should also be changed to "Tool Level" (add @SearchTag("hoe", "axe") for config). Also while you're at it, rename the shsethoelevel command to shsettoollevel and add aliases = listOf("shsethoelevel", "shsetaxelevel")

• Improved Farming Tool Level HUD. - Roboo

Changelog is too vague, please elaborate. For example: "Tool Level Display (formerly Hoe Levels Display) now adapts to the type of tool currently being used."

[github-actions]

25 Detekt Failures

Rule violations

• HoeLevelDisplay.kt#L72 Indentation: Unexpected indentation (3) (should be 4)
• HoeLevelDisplay.kt#L73 Indentation: Unexpected indentation (4) (should be 8)
• HoeLevelDisplay.kt#L74 Indentation: Unexpected indentation (4) (should be 8)
• HoeLevelDisplay.kt#L75 Indentation: Unexpected indentation (4) (should be 8)
• HoeLevelDisplay.kt#L76 Indentation: Unexpected indentation (4) (should be 8)
• HoeLevelDisplay.kt#L78 Indentation: Unexpected indentation (4) (should be 8)
• HoeLevelDisplay.kt#L79 Indentation: Unexpected indentation (4) (should be 8)
• HoeLevelDisplay.kt#L80 Indentation: Unexpected indentation (8) (should be 12)
• HoeLevelDisplay.kt#L81 Indentation: Unexpected indentation (8) (should be 12)
• HoeLevelDisplay.kt#L82 Indentation: Unexpected indentation (8) (should be 12)
• HoeLevelDisplay.kt#L83 Indentation: Unexpected indentation (8) (should be 12)
• HoeLevelDisplay.kt#L84 Indentation: Unexpected indentation (4) (should be 8)
• HoeLevelDisplay.kt#L86 Indentation: Unexpected indentation (4) (should be 8)
• HoeLevelDisplay.kt#L88 Indentation: Unexpected indentation (4) (should be 8)
• HoeLevelDisplay.kt#L89 Indentation: Unexpected indentation (8) (should be 12)
• HoeLevelDisplay.kt#L90 Indentation: Unexpected indentation (4) (should be 8)
• HoeLevelDisplay.kt#L91 Indentation: Unexpected indentation (8) (should be 12)
• HoeLevelDisplay.kt#L92 Indentation: Unexpected indentation (4) (should be 8)
• HoeLevelDisplay.kt#L94 Indentation: Unexpected indentation (4) (should be 8)
• HoeLevelDisplay.kt#L95 Indentation: Unexpected indentation (8) (should be 12)
• HoeLevelDisplay.kt#L96 Indentation: Unexpected indentation (8) (should be 12)
• HoeLevelDisplay.kt#L97 Indentation: Unexpected indentation (8) (should be 12)
• HoeLevelDisplay.kt#L98 Indentation: Unexpected indentation (12) (should be 16)
• HoeLevelDisplay.kt#L99 Indentation: Unexpected indentation (8) (should be 12)
• HoeLevelDisplay.kt#L100 Indentation: Unexpected indentation (4) (should be 8)

[NopoTheGamer]

its called Hoe LevelS because the crop milestone display is called Crop MilestoneS

[NotRoboo]

its called Hoe LevelS because the crop milestone display is called Crop MilestoneS

good point, will revert that if i have time to update before i leave for vacation tmrw

[github-actions]

28 Detekt Failures

Rules flagged (3): MatchingDeclarationName, Filename, Indentation
Files flagged (2): HoeLevelDisplay.kt, MuteHoeLevelUp.kt

Rule violations

• HoeLevelDisplay.kt#L47 MatchingDeclarationName: The file name 'HoeLevelDisplay' does not match the name of the single top-level declaration 'ToolLevelDisplay'.
• HoeLevelDisplay.kt#L1 Filename: File 'HoeLevelDisplay.kt' contains a single top level declaration and should be named 'ToolLevelDisplay.kt'
• HoeLevelDisplay.kt#L74 Indentation: Unexpected indentation (3) (should be 4)
• HoeLevelDisplay.kt#L75 Indentation: Unexpected indentation (4) (should be 8)
• HoeLevelDisplay.kt#L76 Indentation: Unexpected indentation (4) (should be 8)
• HoeLevelDisplay.kt#L77 Indentation: Unexpected indentation (4) (should be 8)
• HoeLevelDisplay.kt#L78 Indentation: Unexpected indentation (4) (should be 8)
• HoeLevelDisplay.kt#L80 Indentation: Unexpected indentation (7) (should be 8)
• HoeLevelDisplay.kt#L81 Indentation: Unexpected indentation (11) (should be 12)
• HoeLevelDisplay.kt#L82 Indentation: Unexpected indentation (11) (should be 12)
• HoeLevelDisplay.kt#L83 Indentation: Unexpected indentation (11) (should be 12)
• HoeLevelDisplay.kt#L84 Indentation: Unexpected indentation (7) (should be 8)
• HoeLevelDisplay.kt#L85 Indentation: Unexpected indentation (7) (should be 8)
• HoeLevelDisplay.kt#L87 Indentation: Unexpected indentation (4) (should be 8)
• HoeLevelDisplay.kt#L89 Indentation: Unexpected indentation (4) (should be 8)
• HoeLevelDisplay.kt#L90 Indentation: Unexpected indentation (8) (should be 12)
• HoeLevelDisplay.kt#L91 Indentation: Unexpected indentation (4) (should be 8)
• HoeLevelDisplay.kt#L92 Indentation: Unexpected indentation (8) (should be 12)
• HoeLevelDisplay.kt#L93 Indentation: Unexpected indentation (4) (should be 8)
• HoeLevelDisplay.kt#L95 Indentation: Unexpected indentation (4) (should be 8)
• HoeLevelDisplay.kt#L96 Indentation: Unexpected indentation (8) (should be 12)
• HoeLevelDisplay.kt#L97 Indentation: Unexpected indentation (8) (should be 12)
• HoeLevelDisplay.kt#L98 Indentation: Unexpected indentation (8) (should be 12)
• HoeLevelDisplay.kt#L99 Indentation: Unexpected indentation (12) (should be 16)
• HoeLevelDisplay.kt#L100 Indentation: Unexpected indentation (8) (should be 12)
• HoeLevelDisplay.kt#L101 Indentation: Unexpected indentation (4) (should be 8)
• MuteHoeLevelUp.kt#L10 MatchingDeclarationName: The file name 'MuteHoeLevelUp' does not match the name of the single top-level declaration 'MuteToolLevelUp'.
• MuteHoeLevelUp.kt#L1 Filename: File 'MuteHoeLevelUp.kt' contains a single top level declaration and should be named 'MuteToolLevelUp.kt'

[NotRoboo]

shouldd be resolved 🤞 however I have to go for a few days so if any more changes ill get back around to it them then

[github-actions]

1 Detekt Failure

• ToolLevelDisplay.kt#L100 Indentation: Unexpected indentation (12) (should be 16)

[github-actions]

2 Detekt Failures

• ToolLevelDisplay.kt#L100 Indentation: Unexpected tab character(s)
• ToolLevelDisplay.kt#L100 Indentation: Unexpected indentation (15) (should be 16)

[github-actions]

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

[lunaynx]

New alpha update:

We've recategorized all Hoes and Axes used for farming into a new "Farming Tool" item type. They now share the same reforges and enchantments for simplicity sake. As a direct result of this, we've removed the Sunder enchantment from the game as it was redundant with the functionality of the Harvesting enchantment, but for Axes.

So might as well make it just always say "Tool". But keep the search tags and command aliases.