Docker single-GPU verification, NVSHMEM/pip build fix, and small runtime fixes#140
Open
rich7420 wants to merge 2 commits intohao-ai-lab:mainfrom
Open
Docker single-GPU verification, NVSHMEM/pip build fix, and small runtime fixes#140rich7420 wants to merge 2 commits intohao-ai-lab:mainfrom
rich7420 wants to merge 2 commits intohao-ai-lab:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nvidia-nvshmem-cu12).rope_scalinghandling whenhf_configis aPretrainedConfigobject.softmax_lseshape assert message indispatch.pyand flash-attn error message infused_comm_attn.py.Changes
Dockerfile,scripts/docker_install_and_build.sh,scripts/run_docker_benchmark.sh,scripts/run_docker_single_gpu_smoke.sh,scripts/run_docker_single_gpu_benchmark.sh,scripts/single_gpu_smoke.sh,scripts/single_gpu_benchmark.sh— one-shot smoke/benchmark (container exits) or interactive shell (container stays).README.md(link to Docker verification),README.Docker.md(step-by-step).csrc/CMakeLists.txt,csrc/cmake/FindNVSHMEM.cmake— support NVSHMEM from pip (noNVSHMEMConfig.cmake).distca/runtime/attn_kernels/dispatch.py(clearer assert),distca/runtime/megatron/ops/fused_comm_attn.py(error text),distca/utils/megatron_test_utils.py(rope_scalingfor config object)..gitignore(e.g.models/,.build/),requirements.txt(transformers pin, comment cleanup).How to verify
From repo root with one GPU:
./scripts/run_docker_single_gpu_smoke.sh