Skip to content

Conversation

@kevin314
Copy link
Collaborator

@kevin314 kevin314 commented Oct 10, 2025

No description provided.

@kevin314 kevin314 marked this pull request as ready for review October 24, 2025 02:30
@kevin314 kevin314 added the go Trigger Buildkite CI label Oct 24, 2025
return x.flatten(-2)


def apply_rotary_emb(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should consider making this cosmos2 specific?

return imgs


def get_timestep_embedding(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also make the architecture specific

timesteps_array = np.linspace(self._sigma_to_t(self.sigma_max),
self._sigma_to_t(self.sigma_min),
num_inference_steps)
t_max = self._sigma_to_t(self.sigma_max)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe make a separate version of this scheduler

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe also separate these

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make arch specific

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test both

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go Trigger Buildkite CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants