Add support for ValueSet.FilterOperator.EQUAL #7012
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Created a new ValueSet resource with ID 2.16.840.1.113762.1.4.1287.10. - Included metadata such as version, last updated date, and profiles. - Added extensions for author, last review date, and effective date. - Defined the ValueSet's URL, identifier, version, name, title, status, date, publisher, and description. - Composed the ValueSet to include ICD-10-CM codes related to esophageal conditions.
fil512
requested changes
Jun 12, 2025
...ir-jpaserver-test-r4/src/test/java/ca/uhn/fhir/jpa/provider/r4/CustomValueSetExpandTest.java
Outdated
Show resolved
Hide resolved
...ir-jpaserver-test-r4/src/test/java/ca/uhn/fhir/jpa/provider/r4/CustomValueSetExpandTest.java
Outdated
Show resolved
Hide resolved
…d importance of the logs
fil512
requested changes
Jul 7, 2025
| code.getDisplay()); | ||
|
|
||
| b.must(f.bool() | ||
| .should(f.match().field("myParentPids").matching("" + code.getId())) |
| } | ||
|
|
||
| // 4. Print all contains | ||
| expanded.getExpansion().getContains().forEach(c -> { |
YES thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to some reason, I need to make ValueSet expand support "EQUAL".
But I don't know how to write JAVA, so I asked GitHub Copilot to help me.
I had tested the code.
This pull request introduces enhancements to the ValueSet expansion functionality in the HAPI FHIR server, including support for new filtering operations and the ability to load and expand a custom ValueSet based on the ICD-10-CM CodeSystem. Key changes include modifying the filtering logic, adding a comprehensive test for ValueSet expansion, and defining a new ValueSet resource.
Enhancements to filtering logic:
TermReadSvcImpl.java: Added support for theEQUAL(=) operator in ValueSet filtering, enabling filtering by specific codes. Includes debug logging for better traceability.New test for ValueSet expansion:
CustomValueSetExpandTest.java: Introduced a new test class to validate the expansion of a custom ValueSet using the ICD-10-CM CodeSystem. The test includes loading the 2023 version of ICD-10-CM, creating a ValueSet, and expanding it using the$expandoperation. It also implements retry logic for robustness.Definition of custom ValueSet resource:
my-valueset.json: Added a new JSON resource defining a custom ValueSet named "Esophageal Metal Stent Placement." The ValueSet includes filters usingdescendent-of,is-a, and=operators on the ICD-10-CM CodeSystem (2023 version).