Bug Fix in PackageInstallerSvcImpl when using MultiTenancy #7092
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lt Tenant ID Set -deprecated method RequestPartitionId.defaultPartition() returns null even when default id is set -under a multitenancy installation; this causes BaseRequestPartitionHelperSvc to throw an error when installing non-partionable resources via system ig loading after changes implimented in version 8.2 -replace with getting id from the partition settings
|
Formatting check succeeded! |
acamarjanovic
approved these changes
Jul 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My issue: #7091 explains the issue.
This PR removes deprecated code in this service and more properly determines the default partition ID using the partition settings.
Includes some basic tests to verify the install occurs on the correct partition.
I couldn't figure out how to write a test that incorporates BaseRequestPartitionHelperSvc from
hapi-fhir-storage, which produces the error.@tadgh (author of #6564)