Server with Spring Boot autoconfiguration should not depend on AbstractJaxRsProvider #7197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkiddo
reviewed
Aug 16, 2025
| @Override | ||
| public void run(String... args) throws Exception { | ||
| fhirClient.capabilities().ofType(CapabilityStatement.class).execute(); | ||
| fhirClient.capabilities().ofType(CapabilityStatement.class) /* .execute() */; |
There was a problem hiding this comment.
Why wouldn't you do the execute invocation here?
There was a problem hiding this comment.
Calling execute would actually execute the request, and fail if there isn't a FHIR server running on localhost:8080.
There was a problem hiding this comment.
Enabled execute again, and added a mock CommandLineRunner in the test class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Autoconfiguration with Spring Boot depends on
AbstractJaxRsProvider, which is in dependencyhapi-fhir-jaxrsserver-base.For simpler server implementations it should be enough to have
hapi-fhir-serveras dependency.