Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/build-cache/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ runs:
using: "composite"
steps:
- name: Set up JDK ${{ inputs.java-version }}
uses: actions/setup-java@v4
uses: actions/setup-java@v5
with:
java-version: ${{ inputs.java-version }}
distribution: "temurin"
Expand Down
4 changes: 2 additions & 2 deletions .github/actions/build-module/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,12 @@ runs:
using: "composite"
steps:
- name: Checkout repository
uses: actions/checkout@v4
uses: actions/checkout@v5
with:
fetch-depth: 1

- name: Set up Java 17
uses: actions/setup-java@v3
uses: actions/setup-java@v5
with:
distribution: 'temurin'
java-version: '17'
Expand Down
4 changes: 2 additions & 2 deletions .github/actions/generate-module-list/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@ runs:
using: 'composite'
steps:
- name: Checkout repository
uses: actions/checkout@v4
uses: actions/checkout@v5

- name: Set up JDK 17
uses: actions/setup-java@v4
uses: actions/setup-java@v5
with:
distribution: 'adopt'
java-version: '17'
Expand Down
2 changes: 1 addition & 1 deletion .github/actions/run-tests-and-archive-results/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ runs:
using: "composite"
steps:
- name: Set up JDK ${{ inputs.java-version }}
uses: actions/setup-java@v4
uses: actions/setup-java@v5
with:
java-version: ${{ inputs.java-version }}
distribution: 'temurin'
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/spotless.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@ jobs:
permissions:
pull-requests: write
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v5
- name: Set up JDK 17
uses: actions/setup-java@v3
uses: actions/setup-java@v5
with:
java-version: '17'
distribution: 'temurin'
Expand Down
1 change: 1 addition & 0 deletions hapi-fhir-android/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@

Original file line number Diff line number Diff line change
Expand Up @@ -463,8 +463,8 @@ private void scanResourceForSearchParams(
@SuppressWarnings("JavadocLinkAsPlainText")
private String toCanonicalSearchParameterUri(RuntimeResourceDefinition theResourceDef, String theName) {
return switch (theName) {
// Hard-code a few URLs that we know don't follow the
// usual pattern
// Hard-code a few URLs that we know don't follow the
// usual pattern
case Constants.PARAM_LANGUAGE -> Constants.PARAM_LANGUAGE_URL;
case Constants.PARAM_TEXT -> Constants.PARAM_TEXT_URL;
case Constants.PARAM_CONTENT -> Constants.PARAM_CONTENT_URL;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
*/
package ca.uhn.fhir.rest.gclient;

import org.checkerframework.checker.nullness.qual.NonNull;
import org.jspecify.annotations.NonNull;

import java.io.InputStream;
import java.util.List;
Expand Down
8 changes: 4 additions & 4 deletions hapi-fhir-base/src/main/java/ca/uhn/fhir/util/UrlUtil.java
Original file line number Diff line number Diff line change
Expand Up @@ -490,10 +490,10 @@ public static String sanitizeUrlPart(CharSequence theString) {

char nextChar = theString.charAt(j);
switch (nextChar) {
/*
* NB: If you add a constant here, you also need to add it
* to isNeedsSanitization()!!
*/
/*
* NB: If you add a constant here, you also need to add it
* to isNeedsSanitization()!!
*/
case '\'':
buffer.append("'");
break;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@
import org.hl7.fhir.instance.model.api.IBaseBundle;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.springframework.util.Base64Utils;

import java.io.BufferedReader;
import java.io.Console;
Expand All @@ -68,6 +67,7 @@
import java.io.InputStreamReader;
import java.io.Reader;
import java.util.Arrays;
import java.util.Base64;
import java.util.Collection;
import java.util.Collections;
import java.util.Date;
Expand Down Expand Up @@ -363,7 +363,7 @@ protected String getAndParseOptionBasicAuthHeader(CommandLine theCommandLine, St
}

byte[] basicAuth = optionValue.getBytes();
String base64EncodedBasicAuth = Base64Utils.encodeToString(basicAuth);
String base64EncodedBasicAuth = Base64.getEncoder().encodeToString(basicAuth);
basicAuthHeaderValue = Constants.HEADER_AUTHORIZATION_VALPREFIX_BASIC + base64EncodedBasicAuth;
}
return basicAuthHeaderValue;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,6 @@
import org.apache.commons.io.IOUtils;
import org.apache.commons.lang3.StringUtils;
import org.apache.commons.lang3.Validate;
import org.checkerframework.checker.nullness.qual.NonNull;
import org.hl7.fhir.instance.model.api.IBase;
import org.hl7.fhir.instance.model.api.IBaseBinary;
import org.hl7.fhir.instance.model.api.IBaseBundle;
Expand All @@ -151,9 +150,11 @@
import org.hl7.fhir.instance.model.api.IBaseResource;
import org.hl7.fhir.instance.model.api.IIdType;
import org.hl7.fhir.instance.model.api.IPrimitiveType;
import org.jspecify.annotations.NonNull;

import java.io.IOException;
import java.io.InputStream;
import java.nio.charset.StandardCharsets;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collection;
Expand Down Expand Up @@ -1424,8 +1425,7 @@ private void addParam(String theName, IBase theValue) {
}

private void addParam(String theName, IQueryParameterType theValue) {
IPrimitiveType<?> stringType =
ParametersUtil.createString(myContext, theValue.getValueAsQueryToken(myContext));
IPrimitiveType<?> stringType = ParametersUtil.createString(myContext, theValue.getValueAsQueryToken());
addParam(theName, stringType);
}

Expand Down Expand Up @@ -2206,11 +2206,11 @@ public OUTPUT execute() {
Map<String, List<String>> params = getParamMap();

for (TokenParam next : myTags) {
addParam(params, Constants.PARAM_TAG, next.getValueAsQueryToken(myContext));
addParam(params, Constants.PARAM_TAG, next.getValueAsQueryToken());
}

for (TokenParam next : mySecurity) {
addParam(params, Constants.PARAM_SECURITY, next.getValueAsQueryToken(myContext));
addParam(params, Constants.PARAM_SECURITY, next.getValueAsQueryToken());
}

for (Collection<String> profileUris : myProfiles) {
Expand Down Expand Up @@ -2281,7 +2281,7 @@ public OUTPUT execute() {

if (myLastUpdated != null) {
for (DateParam next : myLastUpdated.getValuesAsQueryTokens()) {
addParam(params, Constants.PARAM_LASTUPDATED, next.getValueAsQueryToken(myContext));
addParam(params, Constants.PARAM_LASTUPDATED, next.getValueAsQueryToken());
}
}

Expand Down Expand Up @@ -2504,7 +2504,7 @@ public StringOutcome invokeClient(
Map<String, List<String>> theHeaders)
throws IOException, BaseServerResponseException {

String payload = IOUtils.toString(theResponseInputStream, Charsets.UTF_8);
String payload = IOUtils.toString(theResponseInputStream, StandardCharsets.UTF_8);
return new StringOutcome(theResponseStatusCode, payload, theHeaders);
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -90,9 +90,6 @@ public Map<String, Object> getJpaPropertyMap() {
retVal.put(BatchSettings.ORDER_UPDATES, "true");
}

if (!retVal.containsKey(BatchSettings.BATCH_VERSIONED_DATA)) {
retVal.put(BatchSettings.BATCH_VERSIONED_DATA, "true");
}
// Why is this here, you ask? LocalContainerEntityManagerFactoryBean actually clobbers the setting hibernate
// needs in order to be able to resolve beans, so we add it back in manually here
if (!retVal.containsKey(ManagedBeanSettings.BEAN_CONTAINER)) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,12 @@
package ca.uhn.fhir.jpa.model.dialect;

import ca.uhn.fhir.jpa.migrate.DriverTypeEnum;
import org.hibernate.dialect.DerbyDialect;
import org.hibernate.community.dialect.DerbyDialect;
import org.hibernate.engine.jdbc.dialect.spi.DialectResolutionInfo;

/**
* Dialect for Derby database.
* Minimum version: 10.14.2
* Minimum version: 10.15.2
*/
public class HapiFhirDerbyDialect extends DerbyDialect implements IHapiFhirDialect {

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,7 @@ private static class NonConcurrentJobDetailImpl extends JobDetailImpl {

// All HAPI FHIR jobs shouldn't allow concurrent execution
@Override
public boolean isConcurrentExectionDisallowed() {
public boolean isConcurrentExecutionDisallowed() {
return true;
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
*/
package ca.uhn.fhir.jpa.util;

import org.hibernate.dialect.DerbyDialect;
import org.hibernate.community.dialect.DerbyDialect;
import org.hibernate.exception.spi.TemplatedViolatedConstraintNameExtractor;
import org.hibernate.exception.spi.ViolatedConstraintNameExtractor;
import org.slf4j.Logger;
Expand Down
55 changes: 34 additions & 21 deletions hapi-fhir-jpaserver-base/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -520,29 +520,42 @@
<groupId>ca.uhn.hapi.fhir</groupId>
<artifactId>hapi-tinder-plugin</artifactId>
<version>${project.version}</version>
<executions><execution><id>generate-ddl-legacy</id>
<phase>process-classes</phase>
<goals>
<goal>generate-ddl</goal>
</goals>
<configuration>
<databasePartitionMode>false</databasePartitionMode>
<outputDirectory>${project.build.directory}/classes/ca/uhn/hapi/fhir/jpa/docs/database/nonpartitioned</outputDirectory>
</configuration>
</execution>
<execution>
<id>generate-ddl-partitioned</id>
<phase>process-classes</phase>
<goals>
<goal>generate-ddl</goal>
</goals>
<configuration>
<databasePartitionMode>true</databasePartitionMode>
<outputDirectory>${project.build.directory}/classes/ca/uhn/hapi/fhir/jpa/docs/database/partitioned</outputDirectory>
</configuration>
</execution>
<executions>
<execution>
<id>generate-ddl-legacy</id>
<phase>process-classes</phase>
<goals>
<goal>generate-ddl</goal>
</goals>
<configuration>
<databasePartitionMode>false</databasePartitionMode>
<outputDirectory>${project.build.directory}/classes/ca/uhn/hapi/fhir/jpa/docs/database/nonpartitioned</outputDirectory>
</configuration>
</execution>
<execution>
<id>generate-ddl-partitioned</id>
<phase>process-classes</phase>
<goals>
<goal>generate-ddl</goal>
</goals>
<configuration>
<databasePartitionMode>true</databasePartitionMode>
<outputDirectory>${project.build.directory}/classes/ca/uhn/hapi/fhir/jpa/docs/database/partitioned</outputDirectory>
</configuration>
</execution>
</executions>
<configuration>
<fileName/>
<package/>
<packageName/>
<packageName/>
<targetDirectory/>
<version/>
<fhirVersion/>
<configPackageBase/>
<packageBase/>
<targetResourceSpringBeansFile/>
<baseResourceNames/>
<packageNames>
<packageName>ca.uhn.fhir.jpa.entity</packageName>
<packageName>ca.uhn.fhir.jpa.model.entity</packageName>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ public ISearchQueryExecutor searchScrolled(
String theResourceType, SearchParameterMap theParams, RequestDetails theRequestDetails) {
validateHibernateSearchIsEnabled();

SearchQueryOptionsStep<?, JpaPid, SearchLoadingOptionsStep, ?, ?> searchQueryOptionsStep =
SearchQueryOptionsStep<?, ?, JpaPid, SearchLoadingOptionsStep, ?, ?> searchQueryOptionsStep =
getSearchQueryOptionsStep(theResourceType, theParams, null);
logQuery(searchQueryOptionsStep, theRequestDetails);

Expand All @@ -214,7 +214,7 @@ private ISearchQueryExecutor doSearch(
int count = getMaxFetchSize(theParams, theMaxResultsToFetch);

// perform an offset search instead of a scroll one, which doesn't allow for offset
SearchQueryOptionsStep<?, JpaPid, SearchLoadingOptionsStep, ?, ?> searchQueryOptionsStep =
SearchQueryOptionsStep<?, ?, JpaPid, SearchLoadingOptionsStep, ?, ?> searchQueryOptionsStep =
getSearchQueryOptionsStep(theResourceType, theParams, theReferencingPid);
logQuery(searchQueryOptionsStep, theRequestDetails);
List<JpaPid> longs = searchQueryOptionsStep.fetchHits(offset, count);
Expand All @@ -238,11 +238,11 @@ private int getMaxFetchSize(SearchParameterMap theParams, Integer theMax) {
}

@SuppressWarnings("rawtypes")
private SearchQueryOptionsStep<?, JpaPid, SearchLoadingOptionsStep, ?, ?> getSearchQueryOptionsStep(
private SearchQueryOptionsStep<?, ?, JpaPid, SearchLoadingOptionsStep, ?, ?> getSearchQueryOptionsStep(
String theResourceType, SearchParameterMap theParams, IResourcePersistentId theReferencingPid) {

dispatchEvent(IHSearchEventListener.HSearchEventType.SEARCH);
SearchQueryOptionsStep<?, JpaPid, SearchLoadingOptionsStep, ?, ?> query = getSearchSession()
SearchQueryOptionsStep<?, ?, JpaPid, SearchLoadingOptionsStep, ?, ?> query = getSearchSession()
.search(ResourceTable.class)
// The document id is the PK which is pid. We use this instead of _myId to avoid fetching the doc body.
.select(
Expand Down Expand Up @@ -536,7 +536,7 @@ private CompositeProjectionOptionsStep<?, ExtendedHSearchResourceProjection> bui

@Override
public long count(String theResourceName, SearchParameterMap theParams) {
SearchQueryOptionsStep<?, JpaPid, SearchLoadingOptionsStep, ?, ?> queryOptionsStep =
SearchQueryOptionsStep<?, ?, JpaPid, SearchLoadingOptionsStep, ?, ?> queryOptionsStep =
getSearchQueryOptionsStep(theResourceName, theParams, null);

return queryOptionsStep.fetchTotalHitCount();
Expand Down
Loading
Loading