8044 extend transaction log support to batch jobs #7396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion-log-support-to-batch-jobs
ibaisi
requested review from
jamesagnew,
michaelabuckley and
tadgh
as code owners
Contributor
|
Formatting check succeeded! |
ibaisi
changed the title
michaelabuckley
approved these changes
Nov 26, 2025
| * Hooks should return <code>void</code>. | ||
| * </p> | ||
| */ | ||
| BATCH2_JOB_COMPLETION(void.class, "ca.uhn.fhir.batch2.model.JobInstance"), |
Contributor
There was a problem hiding this comment.
suggestion: this should match our other storage names.
Suggested change
| BATCH2_JOB_COMPLETION(void.class, "ca.uhn.fhir.batch2.model.JobInstance"), | |
| STORAGE_POSTCOMPLETE_BATCH_JOB(void.class, "ca.uhn.fhir.batch2.model.JobInstance"), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.