Refactor Patient merge provider for reusability #7397
+791
−72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… invocation This commit introduces a builder pattern for constructing MergeOperationInputParameters, enabling programmatic invocation of Patient $merge operations outside of REST contexts (e.g., Camel, batch jobs, message queues). Changes: - Add MergeOperationInputParametersBuilder with two methods: * fromOperationParams() - Converts REST operation parameters * fromParameters() - Converts FHIR Parameters resource - Refactor PatientMergeProvider to use builder, eliminating duplicate logic - Add comprehensive unit tests (9 test cases covering all parameter types) Benefits: - Single source of truth for parameter conversion - Reusable across REST, Camel, and batch processing contexts - Maintains backward compatibility with existing REST endpoints - Follows FHIR spec for Parameter resource structure 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Contributor
|
Formatting check succeeded! |
Extracted the logic for building FHIR Parameters output from Patient $merge
operation into a reusable utility class. This enables consistent merge output
formatting across different contexts.
Changes:
- Created MergeOperationParametersUtil with two overloaded methods:
- buildMergeOperationOutputParameters(FhirContext, MergeOperationOutcome, IBaseResource)
For callers that have a MergeOperationOutcome object
- buildMergeOperationOutputParameters(FhirContext, IBaseResource, IBaseResource, IBaseResource, IBaseResource)
For callers that have individual components (outcome, updatedTarget, task, input)
- Refactored PatientMergeProvider to delegate to the utility instead of
using private buildMergeOperationOutputParameters method
- Added comprehensive test coverage (5 test cases):
- All components present (both methods)
- Optional components null (both methods)
- Equivalence test verifying both methods produce same output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a builder pattern for constructing MergeOperationInputParameters, enabling programmatic invocation of Patient $merge operations outside of REST contexts (e.g., Camel, batch jobs, message queues).
Changes: