Skip to content

ci: update workflow and readme#56

Merged
wuziqian211 merged 2 commits intohappycola233:mainfrom
Mister-Hope:main
Jan 12, 2026
Merged

ci: update workflow and readme#56
wuziqian211 merged 2 commits intohappycola233:mainfrom
Mister-Hope:main

Conversation

@Mister-Hope
Copy link
Contributor

@Mister-Hope Mister-Hope commented Jan 12, 2026

Fully tested with new code in https://github.com/Mister-Hope/tchMaterial-parser/releases/tag/v3.3-test2

  • Now workflow uses ditto to keep metadata properly while packing.

  • A guideline is added to README.md to explain how to make the Mac app work.

  • workflow config is refined for better readability

  • upx is disabled in config

    Though the Mac's latest runner does not have upx so py-installer won't use it, it can be problematic in some cases; our app is not large enough for introducing a compressor.

Note

I would suggest enabling stripping in other builds, but since I can not test them, I will leave them here.

Copilot AI review requested due to automatic review settings January 12, 2026 04:07
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the CI/CD workflows to use ditto for proper macOS app packaging while preserving metadata, and adds macOS-specific installation instructions to the README. The changes improve formatting consistency across documentation and modernize workflow configurations.

Changes:

  • Updated PyInstaller spec to enable stripping and disable UPX for macOS builds
  • Added macOS installation warning about quarantine attributes and proper app location
  • Modernized GitHub Actions workflows with consistent formatting and better step separation

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
tchMaterial-parser.spec Changed macOS build settings: enabled stripping and disabled UPX compression
README.md Added spacing to section headers, included macOS-specific installation instructions with xattr command
.github/workflows/python-app.yml Updated to actions/checkout@v6, Python 3.14, and improved formatting
.github/workflows/build-release.yml Updated actions versions, improved step separation, replaced zip with ditto for macOS packaging

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Mister-Hope
Copy link
Contributor Author

@wuziqian211 @happycola233 Please review this PR, and probably a new version is needed to ensure the app from actions is runnable.

@wuziqian211 wuziqian211 merged commit b58162e into happycola233:main Jan 12, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants