feat(haproxy): Conditionalize config volumeMount subpath #285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submitted-by: Timur-ND Signed-off-by: Antonio Huete Jimenez <[email protected]>
Thanks-to: Timur-ND Signed-off-by: Antonio Huete Jimenez <[email protected]>
tuxillo
force-pushed
the
fix-conditionalize-config-subpath
branch
from
4d7e66d to
dbd1c01
Compare
tuxillo
changed the title
Member
|
Looks good to me, merging! |
dkorunic
added a commit
that referenced
this pull request
Feb 22, 2025
Changes in haproxy: - Update base image to HAProxy 3.1.5 - Conditionalize config volumeMount subpath (#285) - Conditionalize subPath for haproxy-config configmap - Add deployment annotations as a configurable property. (#281) Signed-off-by: Dinko Korunic <[email protected]>
Contributor
|
The issue is still there, I am not able to disable the subPath option |
Member
|
Hi @c4m4, we are fairly busy but PRs are always welcome in case you have some spare time. Thanks in advance. |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #284