Skip to content

Conversation

@SabaOrk
Copy link
Contributor

@SabaOrk SabaOrk commented Jun 14, 2025

… Dockerfile

@oktalz
Copy link
Member

oktalz commented Jun 14, 2025

@SabaOrk we have a relatively strict policy about commit messages

remove /usr/local/bin/dataplaneapi-v2 & /usr/bin/dataplaneapi-v2 from Dockerfile

can you change commit subject (amend) to be

CLEANUP/MINOR: remove /usr/local/bin/dataplaneapi-v2 & /usr/bin/dataplaneapi-v2 from Dockerfile

I believe that should do it

@SabaOrk SabaOrk changed the title remove /usr/local/bin/dataplaneapi-v2 & /usr/bin/dataplaneapi-v2 from… CLEANUP/MINOR: remove /usr/local/bin/dataplaneapi-v2 & /usr/bin/dataplaneapi-v2 from Dockerfile Jun 14, 2025
@SabaOrk
Copy link
Contributor Author

SabaOrk commented Jun 14, 2025

@oktalz sorry I messed up the commit message while you were doing it, please rename once again, thanks

@SabaOrk
Copy link
Contributor Author

SabaOrk commented Jun 14, 2025

@oktalz I fixed the commit message, please approve the workflow again, thanks!

@oktalz
Copy link
Member

oktalz commented Jun 14, 2025

@SabaOrk it will fail again since for example we require clean git tree, so commits like Merge branch 'patch-1' are also against the policy, but I think I can squash them manually (if not through github interface then completely manually)
plus now we have 5 commits, and I prefer to have just one for this type of change.

no worries, I'll solve it on Monday, thx for PR

@SabaOrk
Copy link
Contributor Author

SabaOrk commented Jun 14, 2025

Got it, thank you very much!

@oktalz
Copy link
Member

oktalz commented Jun 16, 2025

@SabaOrk you commit has been merged as part of the
#726, I'm going to close this one.

thx for the effort !

@oktalz oktalz closed this Jun 16, 2025
@SabaOrk
Copy link
Contributor Author

SabaOrk commented Jun 16, 2025

@oktalz Thank you very much for your work, I will be waiting for the new version of the image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants