more utils #10
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,99 @@ | ||
| #!/usr/bin/python3 | ||
|
|
||
| import ast | ||
| import os | ||
| import os.path | ||
| import sys | ||
|
|
||
| import astor | ||
|
There was a problem hiding this comment. 💡 Verification agent 🧩 Analysis chainVerify dependency: astor present if targeting <3.9. If you intend to support Python <3.9, ensure Run to check packaging references: 🏁 Script executed: #!/bin/bash
set -euo pipefail
echo "Searching packaging for 'astor'…"
fd -t f -a 'pyproject.toml' 'setup.cfg' 'setup.py' 'requirements*.txt' 2>/dev/null | while read -r f; do
echo "==> $f"
rg -n --fixed-strings "astor" "$f" || true
doneLength of output: 32 🏁 Script executed: #!/bin/bash
set -euo pipefail
echo "Listing root directory files:"
ls -1
echo
echo "Finding packaging files:"
find . -maxdepth 2 -type f \( -name 'pyproject.toml' -o -name 'setup.py' -o -name 'setup.cfg' -o -name 'requirements.txt' -o -name 'requirements*.txt' \)
PACK_FILES=$(find . -maxdepth 2 -type f \( -name 'pyproject.toml' -o -name 'setup.py' -o -name 'setup.cfg' -o -name 'requirements.txt' -o -name 'requirements*.txt' \))
if [[ -n "$PACK_FILES" ]]; then
echo
echo "Searching for 'astor' in packaging files:"
echo "$PACK_FILES" | while read -r f; do
echo "==> $f"
rg -n --fixed-strings "astor" "$f" || true
done
fiLength of output: 2739 Add missing astor dependency 🤖 Prompt for AI Agents |
||
|
|
||
|
|
||
| class AddDocString(ast.NodeTransformer): | ||
| def __init__(self, *args, docstring: str, **kwargs): | ||
| """ | ||
| Initialize the AddDocString transformer with the docstring text to insert. | ||
|
|
||
| The provided `docstring` value is stored on the instance as `self.docstring` and will be inserted into any Module, ClassDef, FunctionDef, or AsyncFunctionDef that lacks a docstring. | ||
| Any additional positional and keyword arguments are forwarded to the superclass initializer. | ||
| """ | ||
| super().__init__(*args, **kwargs) | ||
| self.docstring = docstring | ||
|
|
||
| def add_docstring(self, node): | ||
| """ | ||
| Insert the configured docstring into the given AST node if it has no existing docstring. | ||
|
|
||
| If the node (Module, ClassDef, FunctionDef, or AsyncFunctionDef) has no docstring, this function inserts the value of self.docstring as the first statement of node.body. If a docstring already exists, the node is left unchanged. The node is then traversed with generic_visit and returned. | ||
|
|
||
| Parameters: | ||
| node (ast.AST): An AST node that has a `body` sequence (module, class, or function node). | ||
|
|
||
| Returns: | ||
| ast.AST: The (possibly modified) node after applying generic visitation. | ||
| """ | ||
| if ast.get_docstring(node) is None: | ||
| node.body.insert(0, ast.Expr(value=ast.Constant(self.docstring))) | ||
| return self.generic_visit(node) | ||
|
|
||
| def visit_FunctionDef(self, node): | ||
| """ | ||
| Ensure an ast.FunctionDef node has a docstring, inserting the transformer's configured docstring if one is missing, then continue generic traversal. | ||
|
|
||
| Delegates to add_docstring(node) and returns the possibly modified ast.FunctionDef node. | ||
| """ | ||
| return self.add_docstring(node) | ||
|
|
||
| def visit_AsyncFunctionDef(self, node): | ||
| """ | ||
| Visit an async function definition node and ensure it has a docstring. | ||
|
|
||
| If the async function node has no existing docstring, inserts self.docstring | ||
| as the first statement in the node's body. Continues generic AST traversal | ||
| and returns the (possibly modified) node. | ||
|
|
||
| Parameters: | ||
| node (ast.AsyncFunctionDef): The async function AST node to visit. | ||
|
|
||
| Returns: | ||
| ast.AST: The visited (and possibly modified) node. | ||
| """ | ||
| return self.add_docstring(node) | ||
|
|
||
| def visit_ClassDef(self, node): | ||
| """ | ||
| Visit a class definition node and ensure it has a docstring. | ||
|
|
||
| If the class has no docstring, insert the transformer's configured docstring as the first statement. Returns the (possibly modified) AST ClassDef node for further traversal. | ||
|
|
||
| Parameters: | ||
| node (ast.ClassDef): The class definition AST node to visit and potentially modify. | ||
|
|
||
| Returns: | ||
| ast.AST: The transformed ClassDef node. | ||
| """ | ||
| return self.add_docstring(node) | ||
|
|
||
| def visit_Module(self, node): | ||
| """ | ||
| Ensure the given module AST node has a docstring. If the module lacks a docstring, insert the transformer's configured docstring as the first statement, then continue a generic visit of the node's children. | ||
|
|
||
| Parameters: | ||
| node (ast.Module): The module AST node to process. | ||
|
|
||
| Returns: | ||
| ast.AST: The module node after potential modification and traversal. | ||
| """ | ||
| return self.add_docstring(node) | ||
|
|
||
|
|
||
| if __name__ == "__main__": | ||
| converter = AddDocString( | ||
| docstring=os.environ.get("PY_DOCSTRING", "@coderabbitai generate docstrings") | ||
| ) | ||
| for file in sys.argv[1:]: | ||
| with open(file, "rb") as f: | ||
| tree = ast.parse(f.read()) | ||
| result = astor.to_source(converter.visit(tree)) | ||
| file, ext = os.path.splitext(file) | ||
| with open(f"{file}_modified{ext}", "w") as f: | ||
| f.write(result) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -6,66 +6,47 @@ | |||||
| from ast import literal_eval | ||||||
| from datetime import datetime | ||||||
| from shutil import move | ||||||
| import sqlite3 | ||||||
| from peewee import DateTimeField, Model, SqliteDatabase, TextField | ||||||
|
|
||||||
| from color_pprint import cprint | ||||||
| from dateparser import parse | ||||||
| from filelock import FileLock | ||||||
|
|
||||||
| DURATION = re.compile(r"\d{1,2}([:]\d{2})+") | ||||||
| ASSET_PATH = "assets/measurements.db" | ||||||
|
|
||||||
| db = SqliteDatabase(ASSET_PATH) | ||||||
|
|
||||||
| class Measurement(Model): | ||||||
| key = TextField() | ||||||
| value = TextField() | ||||||
| created_date = DateTimeField(default=datetime.now) | ||||||
|
|
||||||
| class Meta: | ||||||
| database = db | ||||||
|
|
||||||
| if __name__ == "__main__": | ||||||
| n = len(sys.argv) | ||||||
| assert ( | ||||||
| n > 1 | ||||||
| ), "You should provide the name of the measurement and the corresponding value" | ||||||
| with FileLock(f"{ASSET_PATH}.lock"): | ||||||
| db.connect() | ||||||
| db.create_tables([Measurement]) | ||||||
| key_dt = timestamp = datetime.now() | ||||||
| dt = timestamp.isoformat() | ||||||
| for i in range(1, n, 2): | ||||||
| key = sys.argv[i] | ||||||
| try: | ||||||
| key, dt2 = key.rsplit("@", 1) | ||||||
| timefilter = dt2 = parse(dt2).replace(tzinfo=None) | ||||||
| if dt2 is not None: | ||||||
| key_dt = dt2.replace(tzinfo=None) | ||||||
| except ValueError: | ||||||
| # key is already fine | ||||||
| timefilter = datetime.min | ||||||
| key_dt = dt | ||||||
| if n > i + 1: | ||||||
| val = sys.argv[i + 1].strip() | ||||||
| if DURATION.fullmatch(val.strip()): | ||||||
|
|
@@ -83,16 +64,9 @@ def filter_dict(data, dt): | |||||
| except ValueError: | ||||||
| pass # keep it a string | ||||||
| if val: # None, False, etc. are all omitted | ||||||
| Measurement.create(created_date=key_dt, key=key, value=json.dumps(val)) | ||||||
| else: | ||||||
| datum = {} | ||||||
| for entry in Measurement.select().where(Measurement.key == key, Measurement.created_date >= timefilter.isoformat()): | ||||||
|
There was a problem hiding this comment. Fix type mismatch in database query. The comparison Apply this diff to compare datetime objects directly: - for entry in Measurement.select().where(Measurement.key == key, Measurement.created_date >= timefilter.isoformat()):
+ for entry in Measurement.select().where(Measurement.key == key, Measurement.created_date >= timefilter):📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||
| datum[parse(entry.created_date).replace(microsecond=0)] = json.loads(entry.value) | ||||||
|
There was a problem hiding this comment. 🛠️ Refactor suggestion | 🟠 Major Remove unnecessary datetime parsing.
Apply this diff to use the datetime object directly: - datum[parse(entry.created_date).replace(microsecond=0)] = json.loads(entry.value)
+ datum[entry.created_date.replace(microsecond=0)] = json.loads(entry.value)📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||
| cprint(datum) | ||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,6 +1,12 @@ | ||||||
| measurements*.json | ||||||
| *_measurements.json | ||||||
| *_measurements.json.gz | ||||||
| measurements*.sqlite3 | ||||||
| *_measurements.sqlite3 | ||||||
| *_measurements.slite3.gz | ||||||
|
There was a problem hiding this comment. Fix typo in file extension. Line 6 contains "slite3" instead of "sqlite3". Apply this diff to fix the typo: -*_measurements.slite3.gz
+*_measurements.sqlite3.gz📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||
| measurements*.db | ||||||
| *_measurements.db | ||||||
| *_measurements.db.gz | ||||||
| list.json | ||||||
| *_list.json | ||||||
| *.lock | ||||||
|
|
||||||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid executing unpinned remote scripts in CI; replace with a local validator or pin to a commit.
curl-ing and executing a remote script from a moving branch (master) is a supply-chain risk and makes builds non-deterministic. Prefer a local validator (no network), or at minimum fetch a specific commit and verify integrity.
Preferred fix: replace the remote script with a Python-based JSON validation that fails the job on invalid JSON.
Alternative (if you must keep the remote script):
📝 Committable suggestion
🤖 Prompt for AI Agents