Add wait_for_acknowledgment support and fix MESSAGE node chaining#578
Merged
Add wait_for_acknowledgment support and fix MESSAGE node chaining#578
Conversation
Allow MESSAGE nodes with `wait_for_ack: true` to pause flow processing and return accumulated messages to the client. The frontend can then auto-continue after a delay (e.g., showing a searching animation). Changes: - Add `wait_for_acknowledgment` field to InteractionResponse schema - Pass wait_for_acknowledgment through the chat API endpoint - Check for wait_for_acknowledgment in QUESTION branch while loop - Rewrite MESSAGE branch in process_interaction to properly chain through ACTION, CONDITION, MESSAGE, and QUESTION nodes when resuming from a paused message (continueFlow) - Fix double-processing bug: skip while loop when awaiting_input is already True, preventing CMS random questions from being fetched twice
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bf964b8766
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
When a MESSAGE node's next node is a QUESTION, persist current_node_id and _current_options via chat_repo.update_session_state so the session points at the correct QUESTION node for the next user response. Also handle the ACTION→QUESTION recursive chain case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wait_for_acknowledgmentsupport so MESSAGE nodes withwait_for_ack: truepause flow processing and return accumulated messages to the client (used for the searching animation in the Huey Bookbot flow)process_interactionto properly chain through ACTION → CONDITION → MESSAGE → QUESTION nodes when resuming from a paused message node (continueFlow)awaiting_inputwas already setTest plan
searching_msgpauses withwait_for_acknowledgment: true→ continue → book recommendations → end_msg → restart_choice