Reimplement PcanBus.fd attribute as read-only property

The property is scheduled for removal in v5.0

Author: lumagi

can/interfaces/pcan/pcan.py

@@ -2,9 +2,10 @@
 Enable basic CAN over a PCAN USB device.
 """
 import logging
+import platform
 import time
+import warnings
 from datetime import datetime
-import platform
 from typing import Optional, List, Tuple, Union, Any
 
 from packaging import version
@@ -70,7 +71,6 @@
     VALID_PCAN_CAN_CLOCKS,
 )
 
-
 # Set up logging
 log = logging.getLogger("can.pcan")
 
@@ -658,6 +658,15 @@ def shutdown(self):
 
         self.m_objPCANBasic.Uninitialize(self.m_PcanHandle)
 
+    @property
+    def fd(self) -> bool:
+        warnings.warn(
+            "The PcanBus.fd property is deprecated and superseded by BusABC.protocol. "
+            "It is scheduled for removal in version 5.0.",
+            DeprecationWarning,
+        )
+        return self.protocol == CanProtocol.CAN_FD
+
     @property
     def state(self):
         return self._state

test/test_pcan.py

@@ -54,6 +54,7 @@ def test_bus_creation(self) -> None:
 
         self.assertIsInstance(self.bus, PcanBus)
         self.assertEqual(self.bus.protocol, CanProtocol.CAN_20)
+        self.assertFalse(self.bus.fd)
 
         self.MockPCANBasic.assert_called_once()
         self.mock_pcan.Initialize.assert_called_once()
@@ -82,6 +83,7 @@ def test_bus_creation_fd(self, clock_param: str, clock_val: int) -> None:
 
         self.assertIsInstance(self.bus, PcanBus)
         self.assertEqual(self.bus.protocol, CanProtocol.CAN_FD)
+        self.assertTrue(self.bus.fd)
 
         self.MockPCANBasic.assert_called_once()
         self.mock_pcan.Initialize.assert_not_called()