Convert BusState to enum when read with configparser #1957
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zariiii9003
reviewed
Jul 21, 2025
can/interfaces/pcan/pcan.py
Outdated
|
|
||
| self.check_api_version() | ||
|
|
||
| if not isinstance(state, BusState): |
Collaborator
There was a problem hiding this comment.
I think this is the wrong place for this. The config value should be converted in can.util._create_bus_config().
Collaborator
|
Could you add a test to |
zariiii9003
reviewed
Jul 22, 2025
test/test_util.py
Outdated
| ) | ||
| state = can_cfg["state"] | ||
| assert isinstance(state, can.BusState) | ||
| assert state == can.BusState.PASSIVE |
Collaborator
There was a problem hiding this comment.
nitpick: enums should be compared by identity (state is can.BusState.PASSIVE)
zariiii9003
reviewed
Jul 22, 2025
test/test_util.py
Outdated
| ) | ||
| state = can_cfg["state"] | ||
| assert isinstance(state, can.BusState) | ||
| assert state == expected_state |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug in pcan interface where state values cannot be read from config files.