reader: mf4: test for 'S' type .Dir like asammdf #1967
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
According to the standard, it should be 0 or 1. |
Contributor
Author
|
Ah ok - unfortunately I don't have access to the specification. I'll create an issue in mdflib instead then. Are you able to provide a snippet of the spec saying this? Do you know why asammdf would support values as string? Is there some legacy non-explicit definition here? |
Collaborator
|
The spec says it's a bit signal, not a string: According to the asammdf commit message, it was added to fix CANalyzer measurements. Anyhow, i guess there's no harm in merging, since this does not affect the files we produce. Could you fix the formatting? |
Contributor
Author
|
Yes I've updated commit with |
zariiii9003
approved these changes
Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I could not decode a mf4 file created by mdflib. It creates
.Dirchannels with string values not int: https://github.com/ihedvall/mdflib/blob/main/mdflib/src/canconfigadapter.cpp#L321Not sure if this is standard in MDF but since the note said the reader iterators are based on the asammdf GUI code, I took a look. It does a check on the attached type.
Commit adds the same for python-can so that it can decode files with a string value for
.Dir.