Skip to content

Fix tests to avoid unclosed files and failed PyPy tests #1968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 5, 2025
Merged

Fix tests to avoid unclosed files and failed PyPy tests #1968

merged 1 commit into from
Aug 5, 2025

Conversation

@zariiii9003
Copy link
Collaborator

@zariiii9003 zariiii9003 commented Aug 5, 2025

Summary of Changes

  • __unused.txt was not explicitly closed which caused warnings on PyPy. These warnings caused other tests to fail, which checked for warnings.

Related Issues / Pull Requests

Type of Change

  • Bug fix
  • New feature
  • Documentation update
  • Refactoring
  • Other (please describe): Improve tests

Checklist

  • I have followed the contribution guide.
  • I have added or updated tests as appropriate.
  • I have added or updated documentation as appropriate.
  • I have added a news fragment for towncrier.
  • All checks and tests pass (tox).

@zariiii9003 zariiii9003 merged commit 963bbee into hardbyte:main Aug 5, 2025
59 of 61 checks passed
@zariiii9003 zariiii9003 deleted the fix-flaky-test branch August 5, 2025 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@zariiii9003