Fix issue with extended_id=None in 3.3.X release #788
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hardbyte
approved these changes
May 23, 2020
Collaborator
|
@zhupumpkin Some tests fail, could you have a look at that? Thanks! |
Owner
|
Ahh sorry I missed this patch for the 3.3.3 release. |
hardbyte
changed the title
Owner
|
Ahh I shouldn't have merged this yet. The tests fail in canutils - but now that I read the linked issue we have always defaulted to an extended id - so I'll revert this as it is behaving as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix issue #787 and want to pull to release-3.3.3