Fix iteration in Bus.stop_all_periodic_tasks #901
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix iteration in Bus.stop_all_periodic_tasks so tasks are properly stopped. In addition, add a test in order to verify that Cyclic Tasks are correctly stopped when multiple tasks are active on a particular bus. The test is carried out via the SocketCAN interface. Note: This is a squashed cherry pick of the following commits from develop: - 8112d13 - 1aa0bc6 Addresses hardbyte#634
Codecov Report
@@ Coverage Diff @@
## release-3.3.4 #901 +/- ##
=================================================
+ Coverage 65.91% 65.92% +0.01%
=================================================
Files 63 63
Lines 5824 5826 +2
=================================================
+ Hits 3839 3841 +2
Misses 1985 1985 |
Collaborator
Author
|
Since |
hardbyte
approved these changes
Aug 26, 2020
Owner
hardbyte
left a comment
hardbyte
left a comment
There was a problem hiding this comment.
⭐
No problem with backporting this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix iteration in Bus.stop_all_periodic_tasks so tasks are properly
stopped.
In addition, add a test in order to verify that Cyclic Tasks are
correctly stopped when multiple tasks are active on a particular bus.
The test is carried out via the SocketCAN interface.
Note: This is a squashed cherry pick of the following commits from
develop:
Addresses #634