-
Notifications
You must be signed in to change notification settings - Fork 17
Refacto theme + DarkMode #331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
❌MegaLinter analysis: Error
Detailed Issues❌ SPELL / cspell - 1 error🤖 AI-Powered Fix Suggestions for SPELL_CSPELL (by google gemini-2.5-flash-lite) 1. Summary of Issues: The primary issue is an "Unknown word (unthemed)" found in 2. How to Fix:
❌ COPYPASTE / jscpd - 1 error🤖 AI-Powered Fix Suggestions for COPYPASTE_JSCPD (by google gemini-2.5-flash-lite) The main issue is the detection of duplicated code by To fix this, refactor the duplicated code into a shared utility function or a common module. This improves maintainability and reduces redundancy.
|
nvuillam
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many of recent updates has been removed , probably during a wrong git merge :/
This PR must contain only theme-related stuff but not impact the working ts/js code ^^
cc @KaspOu
| }); | ||
| } | ||
|
|
||
| handleShowBranchPRs(branchName) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
many of my recent updates has been removed :'(
|
|
||
| const processedTypes = rawData.types.map((type) => { | ||
| const hasWildcard = type.members && type.members.includes("*"); | ||
| const rawMembers = hasWildcard ? [] : type.members || []; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
another example of code that should not have been removed :/
| }); | ||
| } | ||
|
|
||
| openMember(event) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my coooooooode :'( he must remain ^^
| return count > 0 ? `Open ${prLabel} (${count})` : `Open ${prLabel}`; | ||
| } | ||
|
|
||
| get currentPRCardTitle() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code should not have been removed
| this.error = undefined; | ||
| console.log("Mermaid diagram rendered successfully"); | ||
|
|
||
| // Catch clicks on Nodes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
5d6a827 to
e80fb17
Compare
Global theme body ColorThemeMixin for inner theming / refresh Integration Baptiste D CSS Updates for DarkMode
e80fb17 to
6a52f0f
Compare

No description provided.