Add failing ContentFrame test (#1972)

Androbin · kblok · web-flow · commit 04b595bb71fe · 2022-07-09T08:34:34.000-03:00
* Add failing ContentFrame test

* Remove PuppeteerTest attribute

Co-authored-by: Darío Kondratiuk &lt;dariokondratiuk@gmail.com&gt;
diff --git a/lib/PuppeteerSharp.TestServer/wwwroot/frame-example.html b/lib/PuppeteerSharp.TestServer/wwwroot/frame-example.html
@@ -0,0 +1,7 @@
+<html>
+
+  <body>
+    <iframe src="https://example.com"></iframe>
+  </body>
+
+</html>
diff --git a/lib/PuppeteerSharp.Tests/ElementHandleTests/ContentFrameTests.cs b/lib/PuppeteerSharp.Tests/ElementHandleTests/ContentFrameTests.cs
@@ -10,8 +10,12 @@ namespace PuppeteerSharp.Tests.ElementHandleTests
     [Collection(TestConstants.TestFixtureCollectionName)]
     public class ContentFrameTests : PuppeteerPageBaseTest
     {
+        private readonly LaunchOptions _headfulOptions;
+
         public ContentFrameTests(ITestOutputHelper output) : base(output)
         {
+            _headfulOptions = TestConstants.DefaultBrowserOptions();
+            _headfulOptions.Headless =  false;
         }
 
         [PuppeteerTest("elementhandle.spec.ts", "ElementHandle.contentFrame", "should work")]
@@ -24,5 +28,16 @@ public async Task ShouldWork()
             var frame = await elementHandle.ContentFrameAsync();
             Assert.Equal(Page.FirstChildFrame(), frame);
         }
+
+        [PuppeteerFact]
+        public async Task ShouldWorkHeadful()
+        {
+            await using var Browser = await Puppeteer.LaunchAsync(_headfulOptions);
+            await using var Page = await Browser.NewPageAsync();
+            await Page.GoToAsync($"{TestConstants.ServerUrl}/frame-example.html");
+            var elementHandle = await Page.QuerySelectorAsync("iframe");
+            var frame = await elementHandle.ContentFrameAsync();
+            Assert.Equal(Page.FirstChildFrame(), frame);
+        }
     }
 }

-Original file line number
+Diff line change
@@ @@ -0,0 +1,7 @@ @@
 +<html>
++
 +  <body>
 +    <iframe src="https://example.com"></iframe>
 +  </body>
++
 +</html>
Original file line number	Diff line number	Diff line change
`@@ -10,8 +10,12 @@ namespace PuppeteerSharp.Tests.ElementHandleTests`
`10`	`10`	`[Collection(TestConstants.TestFixtureCollectionName)]`
`11`	`11`	`public class ContentFrameTests : PuppeteerPageBaseTest`
`12`	`12`	`{`
	`13`	`+ private readonly LaunchOptions _headfulOptions;`
	`14`	`+`
`13`	`15`	`public ContentFrameTests(ITestOutputHelper output) : base(output)`
`14`	`16`	`{`
	`17`	`+ _headfulOptions = TestConstants.DefaultBrowserOptions();`
	`18`	`+ _headfulOptions.Headless = false;`
`15`	`19`	`}`
`16`	`20`
`17`	`21`	`[PuppeteerTest("elementhandle.spec.ts", "ElementHandle.contentFrame", "should work")]`
`@@ -24,5 +28,16 @@ public async Task ShouldWork()`
`24`	`28`	`var frame = await elementHandle.ContentFrameAsync();`
`25`	`29`	`Assert.Equal(Page.FirstChildFrame(), frame);`
`26`	`30`	`}`
	`31`	`+`
	`32`	`+ [PuppeteerFact]`
	`33`	`+ public async Task ShouldWorkHeadful()`
	`34`	`+ {`
	`35`	`+ await using var Browser = await Puppeteer.LaunchAsync(_headfulOptions);`
	`36`	`+ await using var Page = await Browser.NewPageAsync();`
	`37`	`+ await Page.GoToAsync($"{TestConstants.ServerUrl}/frame-example.html");`
	`38`	`+ var elementHandle = await Page.QuerySelectorAsync("iframe");`
	`39`	`+ var frame = await elementHandle.ContentFrameAsync();`
	`40`	`+ Assert.Equal(Page.FirstChildFrame(), frame);`
	`41`	`+ }`
`27`	`42`	`}`
`28`	`43`	`}`