Skip to content

Commit 28f0354

Browse files
authored
Remove unused members (#2191)
* Remove unused NavigationURL Introduced in fb7c1a4 Unused since 622f1f8 * Removed unused TargetsMap Looks like a leftover from #2051
1 parent 4e03bfc commit 28f0354

File tree

2 files changed

+2
-7
lines changed

2 files changed

+2
-7
lines changed

lib/PuppeteerSharp/ChromeTargetManager.cs

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
using System;
1+
using System;
22
using System.Collections.Concurrent;
33
using System.Collections.Generic;
44
using System.Linq;
@@ -72,8 +72,6 @@ public ChromeTargetManager(
7272

7373
public event EventHandler<TargetChangedArgs> TargetDiscovered;
7474

75-
internal IDictionary<string, Target> TargetsMap { get; }
76-
7775
public ConcurrentDictionary<string, Target> GetAvailableTargets() => _attachedTargetsByTargetId;
7876

7977
public async Task InitializeAsync()
@@ -350,4 +348,4 @@ private void OnDetachedFromTarget(object sender, TargetDetachedFromTargetRespons
350348
TargetGone?.Invoke(this, new TargetChangedArgs { Target = target });
351349
}
352350
}
353-
}
351+
}

lib/PuppeteerSharp/Frame.cs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,6 @@ internal Frame(FrameManager frameManager, string frameId, string parentFrameId,
5151

5252
internal List<string> LifecycleEvents { get; }
5353

54-
internal string NavigationURL { get; private set; }
55-
5654
internal IsolatedWorld MainWorld { get; private set; }
5755

5856
internal IsolatedWorld PuppeteerWorld { get; private set; }
@@ -343,7 +341,6 @@ internal void OnLifecycleEvent(string loaderId, string name)
343341
internal void Navigated(FramePayload framePayload)
344342
{
345343
Name = framePayload.Name ?? string.Empty;
346-
NavigationURL = framePayload.Url + framePayload.UrlFragment;
347344
Url = framePayload.Url + framePayload.UrlFragment;
348345
}
349346

0 commit comments

Comments
 (0)