Remove IsIncognito and some obsolete fields (#2738)

Author: kblok

lib/PuppeteerSharp.DevicesFetcher/Program.cs

@@ -71,14 +71,6 @@ public static class DeviceDescriptors
             new Lazy<IReadOnlyDictionary<DeviceDescriptorName, DeviceDescriptor>>(() => new ReadOnlyDictionary<DeviceDescriptorName, DeviceDescriptor>(Devices));
 
         internal static IReadOnlyDictionary<DeviceDescriptorName, DeviceDescriptor> ToReadOnly() => _readOnlyDevices.Value;
-
-        /// <summary>
-        /// Get the specified device description.
-        /// </summary>
-        /// <returns>The device descriptor.</returns>
-        /// <param name=""name"">Device Name.</param>
-        [Obsolete(""Use Puppeteer.Devices instead"")]
-        public static DeviceDescriptor Get(DeviceDescriptorName name) => Devices[name];
     }
 }";
 

lib/PuppeteerSharp.Tests/BrowserContextTests/BrowserContextTests.cs

@@ -13,9 +13,6 @@ public void ShouldHaveDefaultContext()
         {
             Assert.That(Browser.BrowserContexts(), Has.Exactly(1).Items);
             var defaultContext = Browser.BrowserContexts()[0];
-#pragma warning disable CS0618 // Type or member is obsolete
-            Assert.That(defaultContext.IsIncognito, Is.False);
-#pragma warning restore CS0618 // Type or member is obsolete
             var exception = Assert.ThrowsAsync<PuppeteerException>(defaultContext.CloseAsync);
             Assert.That(Browser.DefaultContext, Is.SameAs(defaultContext));
             Assert.That(exception!.Message, Does.Contain("cannot be closed"));
@@ -26,9 +23,6 @@ public async Task ShouldCreateNewIncognitoContext()
         {
             Assert.That(Browser.BrowserContexts(), Has.Exactly(1).Items);
             var context = await Browser.CreateBrowserContextAsync();
-#pragma warning disable CS0618 // Type or member is obsolete
-            Assert.That(context.IsIncognito, Is.True);
-#pragma warning restore CS0618 // Type or member is obsolete
             Assert.That(Browser.BrowserContexts(), Has.Length.EqualTo(2));
             Assert.That(Browser.BrowserContexts(), Does.Contain(context));
             await context.CloseAsync();

lib/PuppeteerSharp/BrowserContext.cs

@@ -20,9 +20,6 @@ public abstract class BrowserContext : IBrowserContext
         /// <inheritdoc/>
         public string Id { get; protected init; }
 
-        /// <inheritdoc/>
-        public bool IsIncognito => Id != null;
-
         /// <inheritdoc/>
         public bool IsClosed => !Browser.BrowserContexts().Contains(this);
 

lib/PuppeteerSharp/ChromiumProcessException.cs

@@ -15,12 +15,6 @@ public class ConnectOptions : IBrowserOptions, IConnectionOptions
         /// </summary>
         public bool AcceptInsecureCerts { get; set; }
 
-        /// <summary>
-        /// If set to true, sets Headless = false, otherwise, enables automation.
-        /// </summary>
-        [Obsolete("No longer required and usages should be removed")]
-        public bool AppMode { get; set; }
-
         /// <summary>
         /// A browser websocket endpoint to connect to.
         /// </summary>
@@ -37,12 +31,6 @@ public class ConnectOptions : IBrowserOptions, IConnectionOptions
         /// </summary>
         public int SlowMo { get; set; }
 
-        /// <summary>
-        /// Keep alive value.
-        /// </summary>
-        [Obsolete("Chromium doesn't support pings yet (see: https://bugs.chromium.org/p/chromium/issues/detail?id=865002)")]
-        public int KeepAliveInterval { get; set; } = 0;
-
         /// <summary>
         /// Optional factory for <see cref="WebSocket"/> implementations.
         /// If <see cref="Transport"/> is set this property will be ignored.
@@ -55,12 +43,6 @@ public class ConnectOptions : IBrowserOptions, IConnectionOptions
         /// <value>The default Viewport.</value>
         public ViewPortOptions DefaultViewport { get; set; } = ViewPortOptions.Default;
 
-        /// <summary>
-        /// Optional connection transport.
-        /// </summary>
-        [Obsolete("Use " + nameof(TransportFactory) + " instead")]
-        public IConnectionTransport Transport { get; set; }
-
         /// <summary>
         /// Optional factory for <see cref="IConnectionTransport"/> implementations.
         /// </summary>

lib/PuppeteerSharp/ConnectOptions.cs

@@ -40,16 +40,6 @@ public interface IBrowserContext
         /// </summary>
         bool IsClosed { get; }
 
-        /// <summary>
-        /// Returns whether BrowserContext is incognito
-        /// The default browser context is the only non-incognito browser context.
-        /// </summary>
-        /// <remarks>
-        /// The default browser context cannot be closed.
-        /// </remarks>
-        [Obsolete("In Chrome, the default browser context can also be \"icognito\" if configured via the arguments and in such cases this getter returns wrong results. Also, the term \"incognito\" is not applicable to other browsers. To migrate, check the default browser context instead: in Chrome all non-default contexts are incognito, and the default context might be incognito if you provide the `--incognito` argument when launching the browser.")]
-        bool IsIncognito { get; }
-
         /// <summary>
         /// Clears all permission overrides for the browser context.
         /// </summary>

lib/PuppeteerSharp/IBrowserContext.cs

@@ -91,12 +91,6 @@ public bool Devtools
             }
         }
 
-        /// <summary>
-        /// Keep alive value.
-        /// </summary>
-        [Obsolete("Chromium doesn't support pings yet (see: https://bugs.chromium.org/p/chromium/issues/detail?id=865002)")]
-        public int KeepAliveInterval { get; set; } = 0;
-
         /// <summary>
         /// Logs process counts after launching chrome and after exiting.
         /// </summary>
@@ -151,12 +145,6 @@ public string[] IgnoredDefaultArgs
         /// </remarks>
         public WebSocketFactory WebSocketFactory { get; set; }
 
-        /// <summary>
-        /// Optional connection transport.
-        /// </summary>
-        [Obsolete("Use " + nameof(TransportFactory) + " instead")]
-        public IConnectionTransport Transport { get; set; }
-
         /// <summary>
         /// Optional factory for <see cref="IConnectionTransport"/> implementations.
         /// </summary>

lib/PuppeteerSharp/LaunchOptions.cs

@@ -9,7 +9,7 @@ namespace PuppeteerSharp.Mobile
     /// </summary>
     public static class DeviceDescriptors
     {
-        private static readonly Dictionary<DeviceDescriptorName, DeviceDescriptor> Devices = new Dictionary<DeviceDescriptorName, DeviceDescriptor>
+        private static readonly Dictionary<DeviceDescriptorName, DeviceDescriptor> _devices = new()
         {
             [DeviceDescriptorName.BlackberryPlayBook] = new DeviceDescriptor
             {
@@ -1232,15 +1232,7 @@ public static class DeviceDescriptors
         };
 
         private static readonly Lazy<IReadOnlyDictionary<DeviceDescriptorName, DeviceDescriptor>> _readOnlyDevices =
-            new Lazy<IReadOnlyDictionary<DeviceDescriptorName, DeviceDescriptor>>(() => new ReadOnlyDictionary<DeviceDescriptorName, DeviceDescriptor>(Devices));
-
-        /// <summary>
-        /// Get the specified device description.
-        /// </summary>
-        /// <returns>The device descriptor.</returns>
-        /// <param name="name">Device Name.</param>
-        [Obsolete("Use Puppeteer.Devices instead")]
-        public static DeviceDescriptor Get(DeviceDescriptorName name) => Devices[name];
+            new(() => new ReadOnlyDictionary<DeviceDescriptorName, DeviceDescriptor>(_devices));
 
         internal static IReadOnlyDictionary<DeviceDescriptorName, DeviceDescriptor> ToReadOnly() => _readOnlyDevices.Value;
     }

lib/PuppeteerSharp/Mobile/DeviceDescriptors.cs

@@ -5,10 +5,8 @@ namespace PuppeteerSharp
     /// <summary>
     /// process exception thrown by <see cref="Launcher"/>.
     /// </summary>
-#pragma warning disable 612, 618
     [Serializable]
-    public class ProcessException : ChromiumProcessException
-#pragma warning restore 612, 618
+    public class ProcessException : Exception
     {
         /// <summary>
         /// Initializes a new instance of the <see cref="ProcessException"/> class.