Enable Network Service by default (#912)

Author: kblok

lib/PuppeteerSharp.Tests/PageTests/SetRequestInterceptionTests.cs

@@ -438,19 +438,6 @@ public async Task ShouldNavigateToDataURLAndFireDataURLRequests()
             Assert.Equal(dataURL, requests[0].Url);
         }
 
-        [Fact]
-        public async Task ShouldAbortDataServer()
-        {
-            await Page.SetRequestInterceptionAsync(true);
-            Page.Request += async (sender, e) =>
-            {
-                await e.Request.AbortAsync();
-            };
-            var exception = await Assert.ThrowsAsync<NavigationException>(
-                          () => Page.GoToAsync("data:text/html,No way!"));
-            Assert.Contains("net::ERR_FAILED", exception.Message);
-        }
-
         [Fact]
         public async Task ShouldNavigateToURLWithHashAndAndFireRequestsWithoutHash()
         {

lib/PuppeteerSharp/ChromiumProcess.cs

@@ -22,6 +22,7 @@ public class ChromiumProcess : IDisposable
 
         internal static readonly string[] DefaultArgs = {
             "--disable-background-networking",
+            "--enable-features=NetworkService,NetworkServiceInProcess",
             "--disable-background-timer-throttling",
             "--disable-backgrounding-occluded-windows",
             "--disable-breakpad",

lib/PuppeteerSharp/NetworkManager.cs

@@ -342,7 +342,8 @@ private void HandleRequestRedirect(Request request, ResponsePayload responseMess
 
         private async Task OnRequestWillBeSentAsync(RequestWillBeSentPayload e)
         {
-            if (_protocolRequestInterceptionEnabled)
+            // Request interception doesn't happen for data URLs with Network Service.
+            if (_protocolRequestInterceptionEnabled && !e.Request.Url.StartsWith("data:", StringComparison.InvariantCultureIgnoreCase))
             {
                 var requestHash = e.Request.Hash;
                 var interceptionId = _requestHashToInterceptionIds.FirstValue(requestHash);

lib/PuppeteerSharp/Request.cs

@@ -153,6 +153,11 @@ internal Request(
         /// <returns>Task</returns>
         public async Task ContinueAsync(Payload overrides = null)
         {
+            // Request interception is not supported for data: urls.
+            if (Url.StartsWith("data:", StringComparison.InvariantCultureIgnoreCase))
+            {
+                return;
+            }
             if (!_allowInterception)
             {
                 throw new PuppeteerException("Request Interception is not enabled!");
@@ -288,6 +293,11 @@ public async Task RespondAsync(ResponseData response)
         /// <returns>Task</returns>
         public async Task AbortAsync(RequestAbortErrorCode errorCode = RequestAbortErrorCode.Failed)
         {
+            // Request interception is not supported for data: urls.
+            if (Url.StartsWith("data:", StringComparison.InvariantCultureIgnoreCase))
+            {
+                return;
+            }
             if (!_allowInterception)
             {
                 throw new PuppeteerException("Request Interception is not enabled!");