Enable rule SA1202 (#2054)

* Enable SA1101

* Fix BoundingBox

* Fix BrowserFetcher

* Fix CDPSession

* Fix ChromiumLauncher

* Fix Browser

* Fix Connection

* Fix DOMWorld

* Fix Page

* Fix CustomQueriesManager

* Fix ElementHandle

* Fix ExecutionContext

* Fix FirefoxLauncher

* Fix Frame

* Fix FrameManager

* Fix WebSocketTransport

* Fix WaitTask

* Fix Target

* Fix State

* Fix Response

* Fix AXNode

* Fix NetworkManager

* Fix NetworkEventManager

* Fix DeviceDescriptors

* Fix LifecycleWatcher

* Fix LauncherBase

* Fix Launcher

* Fix JSHandle

* Fix Key

* Fix TempDirectory

* Fix TaskQueue

* Fix RemoteObjectHelper

* Fix ConcurrentSet

Author: akshay-zz

lib/PuppeteerSharp.ruleset

@@ -15,7 +15,7 @@
     <Rule Id="SA1629" Action="None" /> <!-- Error SA1629: Documentation text should end with a period (SA1629)-->
     <Rule Id="SA1514" Action="Error" /> <!-- Error SA1514: Element documentation header should be preceded by blank line (SA1514)-->
     <Rule Id="SA1201" Action="Error" /> <!-- Error SA1201: Elements must appear in the correct order (SA1201)-->
-    <Rule Id="SA1202" Action="None" /> <!-- Error SA1202: 'public' members should come before 'internal' members (SA1202)-->
+    <Rule Id="SA1202" Action="Error" /> <!-- Error SA1202: 'public' members should come before 'internal' members (SA1202)-->
     <Rule Id="SA1210" Action="Error" /> <!-- Error SA1210: Using directives should be ordered alphabetically by the namespaces. (SA1210)-->
     <Rule Id="SA1208" Action="Error" /> <!-- Error SA1208: Order usings-->
     <Rule Id="SA1204" Action="Error" /> <!-- Error SA1204: Static members should appear before non-static members (SA1204)-->

lib/PuppeteerSharp/BoundingBox.cs

@@ -55,17 +55,6 @@ public BoundingBox(decimal x, decimal y, decimal width, decimal height)
         /// <value>The height.</value>
         public decimal Height { get; set; }
 
-        internal Clip ToClip()
-        {
-            return new Clip
-            {
-                X = X,
-                Y = Y,
-                Width = Width,
-                Height = Height,
-            };
-        }
-
         /// <inheritdoc/>
         public override bool Equals(object obj)
         {
@@ -96,5 +85,16 @@ public override int GetHashCode()
                 ^ Y.GetHashCode() * 397
                 ^ Width.GetHashCode() * 397
                 ^ Height.GetHashCode() * 397;
+
+        internal Clip ToClip()
+        {
+            return new Clip
+            {
+                X = X,
+                Y = Y,
+                Width = Width,
+                Height = Height,
+            };
+        }
     }
 }

lib/PuppeteerSharp/Browser.cs

@@ -198,10 +198,6 @@ void TargetHandler(object sender, TargetChangedArgs e)
         public void RegisterCustomQueryHandler(string name, CustomQueryHandler queryHandler)
             => CustomQueriesManager.RegisterCustomQueryHandler(name, queryHandler);
 
-        /// <inheritdoc/>
-        internal IEnumerable<string> GetCustomQueryHandlerNames()
-            => CustomQueriesManager.GetCustomQueryHandlerNames();
-
         /// <inheritdoc/>
         public void UnregisterCustomQueryHandler(string name)
             => CustomQueriesManager.UnregisterCustomQueryHandler(name);
@@ -210,6 +206,89 @@ public void UnregisterCustomQueryHandler(string name)
         public void ClearCustomQueryHandlers()
             => CustomQueriesManager.ClearCustomQueryHandlers();
 
+        /// <inheritdoc />
+        public void Dispose()
+        {
+            Dispose(true);
+            GC.SuppressFinalize(this);
+        }
+
+        /// <summary>
+        /// Closes <see cref="Connection"/> and any Chromium <see cref="Process"/> that was
+        /// created by Puppeteer.
+        /// </summary>
+        /// <returns>ValueTask</returns>
+        public ValueTask DisposeAsync() => new ValueTask(CloseAsync());
+
+        internal static async Task<Browser> CreateAsync(
+            Connection connection,
+            string[] contextIds,
+            bool ignoreHTTPSErrors,
+            ViewPortOptions defaultViewPort,
+            LauncherBase launcher,
+            Func<TargetInfo, bool> targetFilter,
+            Action<IBrowser> initAction = null)
+        {
+            var browser = new Browser(connection, contextIds, ignoreHTTPSErrors, defaultViewPort, launcher, targetFilter);
+
+            initAction?.Invoke(browser);
+
+            await connection.SendAsync("Target.setDiscoverTargets", new TargetSetDiscoverTargetsRequest
+            {
+                Discover = true,
+            }).ConfigureAwait(false);
+
+            return browser;
+        }
+
+        /// <inheritdoc/>
+        internal IEnumerable<string> GetCustomQueryHandlerNames()
+            => CustomQueriesManager.GetCustomQueryHandlerNames();
+
+        internal void ChangeTarget(Target target)
+        {
+            var args = new TargetChangedArgs { Target = target };
+            TargetChanged?.Invoke(this, args);
+            ((BrowserContext)target.BrowserContext).OnTargetChanged(this, args);
+        }
+
+        internal async Task<IPage> CreatePageInContextAsync(string contextId)
+        {
+            var createTargetRequest = new TargetCreateTargetRequest
+            {
+                Url = "about:blank",
+            };
+
+            if (contextId != null)
+            {
+                createTargetRequest.BrowserContextId = contextId;
+            }
+
+            var targetId = (await Connection.SendAsync<TargetCreateTargetResponse>("Target.createTarget", createTargetRequest)
+                .ConfigureAwait(false)).TargetId;
+            var target = TargetsMap[targetId];
+            await target.InitializedTask.ConfigureAwait(false);
+            return await target.PageAsync().ConfigureAwait(false);
+        }
+
+        internal async Task DisposeContextAsync(string contextId)
+        {
+            await Connection.SendAsync("Target.disposeBrowserContext", new TargetDisposeBrowserContextRequest
+            {
+                BrowserContextId = contextId,
+            }).ConfigureAwait(false);
+            _contexts.TryRemove(contextId, out var _);
+        }
+
+        /// <summary>
+        /// Closes <see cref="Connection"/> and any Chromium <see cref="Process"/> that was
+        /// created by Puppeteer.
+        /// </summary>
+        /// <param name="disposing">Indicates whether disposal was initiated by <see cref="Dispose()"/> operation.</param>
+        protected virtual void Dispose(bool disposing) => _ = CloseAsync()
+            .ContinueWith(
+                _ => ScreenshotTaskQueue.DisposeAsync(), TaskScheduler.Default);
+
         private async Task CloseCoreAsync()
         {
             try
@@ -259,41 +338,6 @@ private async Task CloseCoreAsync()
             Closed?.Invoke(this, new EventArgs());
         }
 
-        internal void ChangeTarget(Target target)
-        {
-            var args = new TargetChangedArgs { Target = target };
-            TargetChanged?.Invoke(this, args);
-            ((BrowserContext)target.BrowserContext).OnTargetChanged(this, args);
-        }
-
-        internal async Task<IPage> CreatePageInContextAsync(string contextId)
-        {
-            var createTargetRequest = new TargetCreateTargetRequest
-            {
-                Url = "about:blank",
-            };
-
-            if (contextId != null)
-            {
-                createTargetRequest.BrowserContextId = contextId;
-            }
-
-            var targetId = (await Connection.SendAsync<TargetCreateTargetResponse>("Target.createTarget", createTargetRequest)
-                .ConfigureAwait(false)).TargetId;
-            var target = TargetsMap[targetId];
-            await target.InitializedTask.ConfigureAwait(false);
-            return await target.PageAsync().ConfigureAwait(false);
-        }
-
-        internal async Task DisposeContextAsync(string contextId)
-        {
-            await Connection.SendAsync("Target.disposeBrowserContext", new TargetDisposeBrowserContextRequest
-            {
-                BrowserContextId = contextId,
-            }).ConfigureAwait(false);
-            _contexts.TryRemove(contextId, out var _);
-        }
-
         private async void Connection_Disconnected(object sender, EventArgs e)
         {
             try
@@ -402,50 +446,5 @@ private async Task CreateTargetAsync(TargetCreatedResponse e)
                 context.OnTargetCreated(this, args);
             }
         }
-
-        internal static async Task<Browser> CreateAsync(
-            Connection connection,
-            string[] contextIds,
-            bool ignoreHTTPSErrors,
-            ViewPortOptions defaultViewPort,
-            LauncherBase launcher,
-            Func<TargetInfo, bool> targetFilter,
-            Action<IBrowser> initAction = null)
-        {
-            var browser = new Browser(connection, contextIds, ignoreHTTPSErrors, defaultViewPort, launcher, targetFilter);
-
-            initAction?.Invoke(browser);
-
-            await connection.SendAsync("Target.setDiscoverTargets", new TargetSetDiscoverTargetsRequest
-            {
-                Discover = true,
-            }).ConfigureAwait(false);
-
-            return browser;
-        }
-
-        /// <inheritdoc />
-        public void Dispose()
-        {
-            Dispose(true);
-            GC.SuppressFinalize(this);
-        }
-
-        /// <summary>
-        /// Closes <see cref="Connection"/> and any Chromium <see cref="Process"/> that was
-        /// created by Puppeteer.
-        /// </summary>
-        /// <param name="disposing">Indicates whether disposal was initiated by <see cref="Dispose()"/> operation.</param>
-        protected virtual void Dispose(bool disposing) => _ = CloseAsync()
-            .ContinueWith(
-                _ => ScreenshotTaskQueue.DisposeAsync(),
-                TaskScheduler.Default);
-
-        /// <summary>
-        /// Closes <see cref="Connection"/> and any Chromium <see cref="Process"/> that was
-        /// created by Puppeteer.
-        /// </summary>
-        /// <returns>ValueTask</returns>
-        public ValueTask DisposeAsync() => new ValueTask(CloseAsync());
     }
 }