Skip to content

Bidi page browsercontext #2994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: v21
Choose a base branch
from
Open

Bidi page browsercontext #2994

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2249ae6
Bidi: Enable Page.BrowserContext Page.Browser and Page.Close tests
kblok Oct 27, 2025
32472fc
Merge branch 'v21' into bidi-page-browsercontext
kblok Nov 3, 2025
02a345d
Merge remote-tracking branch 'origin/v21' into bidi-page-browsercontext
kblok Nov 4, 2025
c3d5375
implement disconnect
kblok Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions lib/PuppeteerSharp.Nunit/TestExpectations/TestExpectations.local.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -893,21 +893,6 @@
"FAIL"
]
},
{
"comment": "This is part of organizing the webdriver bidi implementation, We will remove it one by one",
"testIdPattern": "[page.spec] *Page.close*",
"platforms": [
"darwin",
"linux",
"win32"
],
"parameters": [
"webDriverBiDi"
],
"expectations": [
"FAIL"
]
},
{
"comment": "This is part of organizing the webdriver bidi implementation, We will remove it one by one",
"testIdPattern": "[page.spec] *Page.exposeFunction*",
Expand Down
15 changes: 14 additions & 1 deletion lib/PuppeteerSharp/Bidi/BidiBrowser.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,11 @@ private BidiBrowser(Core.Browser browserCore, LaunchOptions options, ILoggerFact
public override Task<string> GetUserAgentAsync() => Task.FromResult(BrowserCore.Session.Info.Capabilities.UserAgent);

/// <inheritdoc />
public override void Disconnect() => throw new NotImplementedException();
public override void Disconnect()
{
Driver.StopAsync().GetAwaiter().GetResult();
Detach();
}

/// <inheritdoc />
public override async Task CloseAsync()
Expand Down Expand Up @@ -187,6 +191,15 @@ private void InitializeAsync()
}
}

private void Detach()
{
foreach (var context in _browserContexts)
{
context.TargetCreated -= (sender, args) => OnTargetCreated(args);
context.TargetDestroyed -= (sender, args) => OnTargetDestroyed(args);
}
}

private BidiBrowserContext CreateBrowserContext(UserContext userContext)
{
var browserContext = BidiBrowserContext.From(
Expand Down
Loading