Support subqueries in FROM and JOIN.#250
Open
ChickenProp wants to merge 1 commit intoharelba:masterfrom
Open
Conversation
Owner
|
Hi @ChickenProp ! thanks for the PR. I'm in the middle of a huge change inside q's code which should provide a large improvement. I'll take a deeper look into it when i'm done. |
Author
|
@harelba gentle ping :) I see there's been some big changes, is this something you're in a position to look at now? (I confess I haven't actually checked if this still works.) |
Owner
|
thanks for the ping @ChickenProp Indeed, I've released a very large change, although it doesn't include changes to the query parsing itself. I was planning a major change in query parsing, but it's a very big task, and most use-cases are covered by the current "parsing". I'll take a look to see if I can introduce a smaller change that will accommodate this use-case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I may be missing something, but from my simple experiments so far this seems to work.
If you'd be amenable to adding this, I'll be happy to add tests and change documentation as necessary.