Skip to content

Add an empty [tool.setuptools_scm] section to pyproject.toml#231

Closed
musicinmybrain wants to merge 1 commit intoharfbuzz:mainfrom
musicinmybrain:setuptools_scm-key
Closed

Add an empty [tool.setuptools_scm] section to pyproject.toml#231
musicinmybrain wants to merge 1 commit intoharfbuzz:mainfrom
musicinmybrain:setuptools_scm-key

Conversation

@musicinmybrain
Copy link
Contributor

See https://setuptools-scm.readthedocs.io/en/latest/usage/. This section is expected to be present, but it may be empty if no non-default settings are required.

This addition does not change the contents of the binary wheels.

Fixes:

$ python3 -m build
[…]
WARNING setuptools_scm.pyproject_reading toml section missing 'pyproject.toml does not contain a tool.setuptools_scm section'
Traceback (most recent call last):
  File "/tmp/build-env-sgdlgtss/lib64/python3.13/site-packages/setuptools_scm/_integration/pyproject_reading.py", line 36, in read_pyproject
    section = defn.get("tool", {})[tool_name]
              ~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^
KeyError: 'setuptools_scm'

See https://setuptools-scm.readthedocs.io/en/latest/usage/. This section
is expected to be present, but it may be empty if no non-default
settings are required.

This addition does not change the contents of the binary wheels.
@musicinmybrain
Copy link
Contributor Author

Hmm, this fails on ubuntu-latest (only):

  =================================== FAILURES ===================================
  ____________________________ test_uharfbuzz_version ____________________________
  
      def test_uharfbuzz_version():
          v = hb.__version__
          assert isinstance(v, str)
  >       assert "unknown" not in v
  E       AssertionError: assert 'unknown' not in '0.0.0+unknown'
  E         
  E         'unknown' is contained here:
  E           0.0.0+unknown
  
  /project/tests/test_uharfbuzz.py:1607: AssertionError

I’m not quite sure at a glance what it would take to make this work on all supported platforms, so – since this “only” fixes a warning – I’ll close this PR for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant