adding Arabic Localization#132
Conversation
Summary of ChangesHello @Quartz313, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the application's internationalization by integrating a new Arabic localization. The changes include the addition of a dedicated translation file with standard Arabic phrases and necessary updates to the application's language configuration and documentation to support this new language option. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
Thank you for your contribution in adding Arabic localization. This is a great addition to the project. I've reviewed the changes and found a few minor issues in the new localization file, mostly related to consistency, typos, and grammar. I've also noted a small formatting issue in the README.md and index.json files. My detailed feedback is in the comments below.
| "GITHUB": "GitHub", | ||
| "GO_TO_SETTINGS": "الذهاب للإعدادات", | ||
| "HIDE": "إخفاء", | ||
| "HIDE_LYRICS": "إخفاء كلمات الاغنية", |
There was a problem hiding this comment.
The translation for HIDE_LYRICS is "إخفاء كلمات الاغنية" (Hide song lyrics), using the singular form for "song". However, the translation for LYRICS on line 109 is "كلمات الأغاني" (songs' lyrics), which is plural. For consistency, it would be better to use the plural form here as well.
| "HIDE_LYRICS": "إخفاء كلمات الاغنية", | |
| "HIDE_LYRICS": "إخفاء كلمات الأغاني", |
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Not everyone understands the English term "URL" Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
We order it alphabetically based on language code. So you can change the order in README.md & index.json. Thanks! |
|
reordering done. |
|
Thanks! |
here's my attempt to translate the app to the standard Arabic which is understandable across the middle east.