Merge pull request #100 from harness/FFM-5103

[FFM-5103] changed prereq matches from value to identifer

Author: laura135

evaluation/feature.go

@@ -315,7 +315,7 @@ func prereqsSatisfied(fc FeatureConfig, target *Target, flags map[string]Feature
 
 		if pre.Feature == prereqFlag.Feature {
 			for _, variation := range pre.Variations {
-				if variation != variationToMatch.Value {
+				if variation != variationToMatch.Identifier {
 					return false
 				}
 			}
@@ -565,7 +565,7 @@ func checkPreReqsForPreReqs(preReqFlagPreReqs []Prerequisite, flags map[string]F
 		preReqVariationToMatch := nestedPreReq.Variations.FindByIdentifier(nestedPreReq.GetVariationName(target))
 		if preReq.Feature == nestedPreReq.Feature {
 			for _, variation := range preReq.Variations {
-				if variation != preReqVariationToMatch.Value {
+				if variation != preReqVariationToMatch.Identifier {
 					return false
 				}
 			}

evaluation/feature_test.go

@@ -546,13 +546,13 @@ func TestFeatureConfig_EvaluateWithPreReqFlags(t *testing.T) {
 	onBool := Variation{
 		Name:       stringPtr("On"),
 		Value:      "true",
-		Identifier: "on",
+		Identifier: "true",
 	}
 
 	offBool := Variation{
 		Name:       stringPtr("Off"),
 		Value:      "false",
-		Identifier: "off",
+		Identifier: "false",
 	}
 
 	target := Target{