Incorporate feedback from Flathub review#559
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds functionality to support the requirements for inclusion in Flathub. This will be ported to the
0.3.3tag as well, but since it only affects Flatpak behavior, we won't do another release.We lose access to popping the log viewer within the Flatpak, so this adds a small form for viewing logs (can and should be improved). Additionally, users upgrading may be confused as to where their projects have gone, so this prompts them to port them into the flatpak data.
Pending feedback from Flathub folks, this also introduces a custom DLL import resolver for NAudio.SDL2's importing of the SDL binary -- when it detects that it's inside a Flatpak, it changes what it's looking for. This might be removed before merging if it ends up not being necessary.