Improve register naming conventions and regenerate interface #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Description strings have also been added for missing enum values and updated for consistency.
| description: Configuration of the digital input 1 (DI1) | ||
| SoundOrFrequencyDI0: &soundIndex | ||
| description: Specifies the configuration for the digital input 1 (DI1). | ||
| StartDI0: &soundIndex |
Member
There was a problem hiding this comment.
Suggested change
| StartDI0: &soundIndex | |
| StartOnDI0: &soundIndex |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR directly addresses the remaining review comments for the v3.0 firmware branch and regenerates the interface to prepare for a joint release.
I was originally planning to refactor the firmware naming itself which has now drifted significantly away from the spec in the
device.yml. The work in harp-tech/reflex-generator#85 is a direct result of this. There are only a few minor outstanding issues, but unfortunately they do need to be resolved together before moving forward, so I decided to restrict the refactoring purely to the interface for now.