Skip to content

Add favicons by Nadège#39

Open
NadegeBocoAssogba wants to merge 1 commit intohartman:masterfrom
NadegeBocoAssogba:master
Open

Add favicons by Nadège#39
NadegeBocoAssogba wants to merge 1 commit intohartman:masterfrom
NadegeBocoAssogba:master

Conversation

@NadegeBocoAssogba
Copy link
Copy Markdown

I added favicon.png, favicon.ico and favicon.svg in the html code.

@bunnypranav
Copy link
Copy Markdown

@hugolpz
Copy link
Copy Markdown

hugolpz commented Apr 15, 2025

@bunnypranav, Nadege was a one-shot participants to a Wikimedia Hackathon. This hackathon is over. Since this is a very safe favicon submission, I encourage the Zonestamp team to just merge her PR. If you later create a more elegant icon you can update the images files alone. cc @hartman

@hartman
Copy link
Copy Markdown
Owner

hartman commented Apr 16, 2025

I'll merge it when I have time to return to the zonestamp project. Maybe this weekend or next weekend.

Copy link
Copy Markdown
Owner

@hartman hartman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution Nadège !

I would like to credit you in the ReadMe file. Can you share how you would like to be listed ? Name or GitHub pseudonym, and if you would like to add a particular email address to the credit ?

<!-- Favicon pour Apple Touch (mobile) -->
<link rel="apple-touch-icon" sizes="180x180" href="./favicon ico/apple-touch-icon.png" />
<!-- Manifest Web (pour les applications web progressives) -->
<link rel="manifest" href="./favicon ico/site.webmanifest" />
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This adds a secondary manifest file and I'm not sure why ?

@NadegeBocoAssogba
Copy link
Copy Markdown
Author

NadegeBocoAssogba commented May 11, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants