Conversation
|
@bunnypranav, Nadege was a one-shot participants to a Wikimedia Hackathon. This hackathon is over. Since this is a very safe favicon submission, I encourage the Zonestamp team to just merge her PR. If you later create a more elegant icon you can update the images files alone. cc @hartman |
|
I'll merge it when I have time to return to the zonestamp project. Maybe this weekend or next weekend. |
hartman
left a comment
There was a problem hiding this comment.
Thank you for your contribution Nadège !
I would like to credit you in the ReadMe file. Can you share how you would like to be listed ? Name or GitHub pseudonym, and if you would like to add a particular email address to the credit ?
| <!-- Favicon pour Apple Touch (mobile) --> | ||
| <link rel="apple-touch-icon" sizes="180x180" href="./favicon ico/apple-touch-icon.png" /> | ||
| <!-- Manifest Web (pour les applications web progressives) --> | ||
| <link rel="manifest" href="./favicon ico/site.webmanifest" /> |
There was a problem hiding this comment.
This adds a secondary manifest file and I'm not sure why ?
|
Thank you!
You can use my GitHub name.
And u can add my email ***@***.***
…On Fri, May 2, 2025, 9:44 AM Derk-Jan Hartman ***@***.***> wrote:
***@***.**** commented on this pull request.
Thank you for your contribution Nadège !
I would like to credit you in the ReadMe file. Can you share how you would
like to be listed ? Name or GitHub pseudonym, and if you would like to add
a particular email address to the credit ?
------------------------------
In public/index.html
<#39 (comment)>:
> <link href="https://fonts.googleapis.com/css?family=Lobster|Quicksand:400,700" rel="stylesheet">
<meta name="viewport" content="width=device-width, initial-scale=1, shrink-to-fit=no">
<meta name="theme-color" content="#0c7fa2">
+ <link rel="icon" type="image/png" sizes="16x16" href="favicon/favicon-16x16.png">
+ <link rel="icon" type="image/png" sizes="32x32" href="favicon/favicon-32x32.png">
+ <link rel="icon" type="image/png" sizes="48x48" href="favicon/favicon-48x48.png">
+ <link rel="icon" type="image/png" sizes="64x64" href="favicon/favicon-64x64.png">
+ <link rel="icon" type="image/png" sizes="128x128" href="favicon/favicon-128.png">
+
+ <!-- Favicon SVG (pour les navigateurs modernes) -->
+ <link rel="icon" type="image/svg+xml" href="./favicon/ZoneStamp-logo.svg">
+ <!-- Favicon.ico (pour une compatibilité maximale avec les anciens navigateurs) -->
+ <link rel="shortcut icon" href="./favicon ico/favicon.ico" />
+ <!-- Favicon pour Apple Touch (mobile) -->
+ <link rel="apple-touch-icon" sizes="180x180" href="./favicon ico/apple-touch-icon.png" />
+ <!-- Manifest Web (pour les applications web progressives) -->
+ <link rel="manifest" href="./favicon ico/site.webmanifest" />
This adds a secondary manifest file and I'm not sure why ?
—
Reply to this email directly, view it on GitHub
<#39 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BN2AWJADLLGQ64G4C6FHIM324MV7HAVCNFSM6AAAAAB2CVD2UKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDQMJRGQZTQMJTG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
I added favicon.png, favicon.ico and favicon.svg in the html code.