minter: add BAI minter

 * INSPIR-3209

Author: Pawel Zembrzuski

backend/inspirehep/pidstore/api/authors.py

@@ -4,7 +4,7 @@
 #
 # inspirehep is free software; you can redistribute it and/or modify it under
 # the terms of the MIT License; see LICENSE file for more details.
-
+from inspirehep.pidstore.minters.bai import BAIMinter
 
 from ..minters.control_number import AuthorsMinter
 from ..minters.orcid import OrcidMinter
@@ -13,4 +13,4 @@
 
 class PidStoreAuthors(PidStoreBase):
 
-    minters = [AuthorsMinter, OrcidMinter]
+    minters = [AuthorsMinter, OrcidMinter, BAIMinter]

backend/inspirehep/pidstore/minters/bai.py

@@ -0,0 +1,17 @@
+# -*- coding: utf-8 -*-
+#
+# Copyright (C) 2019 CERN.
+#
+# inspirehep is free software; you can redistribute it and/or modify it under
+# the terms of the MIT License; see LICENSE file for more details.
+
+from inspire_utils.record import get_values_for_schema
+
+from inspirehep.pidstore.minters.base import Minter
+
+
+class BAIMinter(Minter):
+    pid_type = "bai"
+
+    def get_pid_values(self):
+        return get_values_for_schema(self.data.get("ids", []), "INSPIRE BAI")

backend/tests/helpers/providers/record_provider.py

@@ -17,28 +17,36 @@
 
 
 class RecordProvider(BaseProvider):
-    def control_number(self):
+    @staticmethod
+    def control_number():
         return fake.random_number(digits=8, fix_len=True)
 
-    def doi(self):
+    @staticmethod
+    def doi():
         return "10.{}/{}".format(
             fake.random_number(digits=4, fix_len=True),
             fake.random_number(digits=8, fix_len=True),
         )
 
-    def arxiv(self):
+    @staticmethod
+    def arxiv():
         return "20{}.{}".format(
             fake.random_number(digits=2, fix_len=True),
             fake.random_number(digits=5, fix_len=True),
         )
 
-    def orcid(self):
+    @staticmethod
+    def orcid():
         return "0000-{}-{}-{}".format(
             fake.random_number(digits=4, fix_len=True),
             fake.random_number(digits=4, fix_len=True),
             fake.random_number(digits=4, fix_len=True),
         )
 
+    @staticmethod
+    def bai():
+        return f"{fake.name().replace(' ', '.')}.{fake.random_number(digits=1)}"
+
     @staticmethod
     def hep_record():
         return {
@@ -48,8 +56,8 @@ def hep_record():
             "_collections": ["Literature"],
         }
 
-    @staticmethod
-    def author_record():
+    @classmethod
+    def author_record(cls):
         return {
             "$schema": "http://localhost:5000/schemas/records/authors.json",
             "name": {"value": fake.name()},
@@ -124,6 +132,18 @@ def add_data_citations(citation_records):
             )
         return {"references": data}
 
+    @classmethod
+    def add_other_pids(cls, pids):
+        if not pids:
+            return
+        ids = []
+        for pid in pids:
+            if pid == "orcid":
+                ids.append({"schema": "ORCID", "value": cls.orcid()})
+            if pid == "bai":
+                ids.append({"schema": "INSPIRE BAI", "value": cls.bai()})
+        return ids
+
     def record(
         self,
         record_type,
@@ -132,6 +152,7 @@ def record(
         literature_citations=[],  # TODO: call `literature_references`
         data_citations=[],
         skip_validation=False,
+        other_pids=[],
     ):
         if record_type == "lit":
             record = self.hep_record()
@@ -149,7 +170,6 @@ def record(
             record = self.data_record()
         elif record_type == "ins":
             record = self.institutions_record()
-
         if with_control_number:
             record["control_number"] = self.control_number()
         if data:
@@ -158,6 +178,10 @@ def record(
             record.update(self.add_citations(literature_citations))
         if data_citations:
             record.update(self.add_data_citations(data_citations))
+        if other_pids:
+            ids = record.get("ids", [])
+            ids.extend(self.add_other_pids(other_pids))
+            record["ids"] = ids
         if not skip_validation:
             schema_validate(record)
         return record

backend/tests/integration/pidstore/minters/test_minters_bai.py

@@ -0,0 +1,69 @@
+# -*- coding: utf-8 -*-
+#
+# Copyright (C) 2019 CERN.
+#
+# inspirehep is free software; you can redistribute it and/or modify it under
+# the terms of the MIT License; see LICENSE file for more details.
+
+
+import pytest
+from helpers.providers.faker import faker
+from invenio_pidstore.models import PersistentIdentifier, PIDStatus
+
+from inspirehep.pidstore.errors import PIDAlreadyExists
+from inspirehep.pidstore.minters.bai import BAIMinter
+from inspirehep.records.api import AuthorsRecord
+
+
+def test_minter_bai(base_app, db, es, create_record):
+    data = {"ids": [{"schema": "JACOW", "value": "JACoW-12345678"}]}
+    record_data = faker.record("aut", data=data, other_pids=["bai"])
+    BAIMinter.mint(None, record_data)
+    expected_pids_len = 1
+    epxected_pids_values = [record_data["ids"][1]["value"]]
+    expected_pids_provider = "external"
+    expected_pids_status = PIDStatus.REGISTERED
+    result_pids = (
+        PersistentIdentifier.query.filter_by(object_uuid=None)
+        .filter_by(pid_type="bai")
+        .all()
+    )
+    result_pids_len = len(result_pids)
+
+    assert expected_pids_len == result_pids_len
+
+    pid = result_pids[0]
+    assert expected_pids_provider == pid.pid_provider
+    assert expected_pids_status == pid.status
+    assert pid.pid_value in epxected_pids_values
+
+
+def test_minter_bai_empty(base_app, db, es, create_record):
+    record_data = faker.record("aut")
+    BAIMinter.mint(None, record_data)
+
+    expected_pids_len = 0
+
+    result_pids_len = PersistentIdentifier.query.filter_by(
+        object_uuid=None, pid_type="bai"
+    ).count()
+
+    assert expected_pids_len == result_pids_len
+
+
+def test_minter_bai_already_existing(base_app, db, es, create_record):
+    data = faker.record("aut", other_pids=["bai"])
+    BAIMinter.mint(None, data)
+    data2 = {"ids": data["ids"]}
+    record_data2 = faker.record("aut", data2)
+    with pytest.raises(PIDAlreadyExists):
+        BAIMinter.mint(None, record_data2)
+
+
+def test_if_bai_is_processed_on_authors_record_creation(base_app, db, es):
+    data = faker.record("aut", other_pids=["bai"])
+    bai = data["ids"][0]["value"]
+    rec = AuthorsRecord.create(data)
+    assert (
+        PersistentIdentifier.query.filter_by(pid_type="bai", pid_value=bai).count() == 1
+    )