fix: handle null synced_modules in sync progress response#1218
Open
adityamulik wants to merge 1 commit intoharvard-edge:mainfrom
Open
fix: handle null synced_modules in sync progress response#1218adityamulik wants to merge 1 commit intoharvard-edge:mainfrom
adityamulik wants to merge 1 commit intoharvard-edge:mainfrom
Conversation
github-actions
bot
added
area: book
Contributor
Author
|
@profvjreddi please let me know if this change is needed as well as I opened it to merge in main instead of dev (I can create a separate PR, if needed). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Desc:
Handle null synced_modules in sync progress response.
Fall back to showing completed module count when API returns null.
Before:
After:
