Skip to content

fix: handle null synced_modules in sync progress response #1218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adityamulik wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: handle null synced_modules in sync progress response #1218

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion tinytorch/tito/core/submission.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,14 @@ def sync_progress(self, total_modules: int = 20, is_retry: bool = False) -> bool
if 200 <= response.status < 300:
resp_body = json.loads(response.read().decode('utf-8'))
self.console.print("✅ [bold green]Sync Successful![/bold green]")
self.console.print(f" Modules Synced: {resp_body.get('synced_modules', 'N/A')}")
# Handle synced_modules - show count of modules that were synced
synced = resp_body.get('synced_modules')
if synced is not None:
self.console.print(f" Modules Synced: {synced}")
else:
# If null, show the count of completed modules that were sent
completed_count = payload['module_progress']['completed_count']
self.console.print(f" Modules Synced: {completed_count} completed module(s)")
return True
else:
self.console.print(f"⚠️ Server returned status: {response.status}")
Expand Down