(Tentative) Move SSL capture to ScoopProxy#140
Draft
matteocargnelutti wants to merge 2 commits intomainfrom
Draft
(Tentative) Move SSL capture to ScoopProxy#140matteocargnelutti wants to merge 2 commits intomainfrom
matteocargnelutti wants to merge 2 commits intomainfrom
Conversation
Implements #138 --- - Removes `crip` dependency, dedicated certificates capture step and associated options. - Intercepts certificate chain at `ScoopProxy` level using `socket.getPeerCertificate()` to assemble a PEM on the fly. Runs once per origin. - Removes duplicate processing of `noarchive` checks --- **Still working through:** The certificates interception currently happens at `ScoopProxy.onResponse()` level. It should be in `ScoopProxy.onConnected()`, but in some cases it appears to be _"too early"_. TBD, but this version works.
Contributor
Author
|
Update: This works in most cases, but during my tests I've observed inconsistent behavior. Looking into it, but setting this PR as draft in the meantime, as I don't know if this method of capture will end up being suitable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #138
cripdependency, dedicated certificates capture step, and associated options.ScoopProxylevel usingsocket.getPeerCertificate()to assemble a PEM on the fly. Runs once per origin.noarchivechecksStill working through:
ScoopProxy.onResponse()level.It should be in
ScoopProxy.onConnected(), but in some cases it appears to be "too early".TBD, but this version works.