Skip to content

Release Forklift chart v1.8.0 dev.0#480

Merged
ibrokethecloud merged 1 commit intoharvester:releasefrom
ibrokethecloud:forklift-v1.8.0-dev.0
Mar 12, 2026
Merged

Release Forklift chart v1.8.0 dev.0#480
ibrokethecloud merged 1 commit intoharvester:releasefrom
ibrokethecloud:forklift-v1.8.0-dev.0

Conversation

@ibrokethecloud
Copy link
Copy Markdown
Contributor

Problem:

PR cherry picks commits
c22c93b8060b6c5fc620d4b006dd9af3ef27a9fd
96d9b53e7005782490186dc4ba7dd33e4fb95cd4
from master and adds a version to allow chart release for forklift-operator

Solution:

Related Issue(s):

https://github.com/harvester/suse-virtualization-mgmt/issues/18

Test plan:

Additional documentation or context

Copilot AI review requested due to automatic review settings March 5, 2026 03:42
@ibrokethecloud ibrokethecloud requested review from Yu-Jack and bk201 March 5, 2026 03:43
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces the forklift-operator Helm chart content (templates, CRDs, RBAC, and defaults) and bumps the chart version to 1.8.0-dev.0 to enable chart publishing for the forklift-operator.

Changes:

  • Add the forklift-operator chart metadata (Chart.yaml), defaults (values.yaml), and Helm boilerplate (.helmignore, helpers).
  • Add the operator Deployment template wired to image/tag values and environment variables for related component images.
  • Add required Kubernetes manifests for the operator stack: ServiceAccounts, RBAC, and Forklift CRDs.

Reviewed changes

Copilot reviewed 22 out of 22 changed files in this pull request and generated no comments.

Show a summary per file
File Description
charts/forklift-operator/Chart.yaml Defines chart metadata and sets chart/app versions for release.
charts/forklift-operator/.helmignore Adds standard Helm packaging ignore patterns.
charts/forklift-operator/values.yaml Provides default image settings, args, env, and scheduling knobs for the operator deployment.
charts/forklift-operator/templates/_helpers.tpl Adds standard Helm helper templates for names/labels/selectors.
charts/forklift-operator/templates/deployment.yaml Deploys the forklift operator (ansible) with configured images/env/health probes.
charts/forklift-operator/templates/serviceaccount.yaml Creates ServiceAccounts used by the operator and related controllers.
charts/forklift-operator/templates/manager-rbac.yaml ClusterRole/Binding for manager/operator-level permissions.
charts/forklift-operator/templates/leader-election-rbac.yaml Role/RoleBinding used by the operator for leader-election and namespaced access.
charts/forklift-operator/templates/forklift-controller-rbac.yaml ClusterRole/Binding for the forklift controller permissions.
charts/forklift-operator/templates/forklift-populator-controller-rbac.yaml ClusterRole/Binding for the populator controller permissions.
charts/forklift-operator/templates/forklift-api-rbac.yaml ClusterRole/Binding for the forklift API permissions.
charts/forklift-operator/templates/forkliftcontroller-crd.yaml Adds the ForkliftController CRD.
charts/forklift-operator/templates/hook-crd.yaml Adds the Hook CRD.
charts/forklift-operator/templates/host-crd.yaml Adds the Host CRD.
charts/forklift-operator/templates/migration-crd.yaml Adds the Migration CRD.
charts/forklift-operator/templates/networkmap-crd.yaml Adds the NetworkMap CRD.
charts/forklift-operator/templates/storagemap-crd.yaml Adds the StorageMap CRD.
charts/forklift-operator/templates/provider-crd.yaml Adds the Provider CRD.
charts/forklift-operator/templates/plan-crd.yaml Adds the Plan CRD (largest schema).
charts/forklift-operator/templates/ovirtvolumepopulator-crd.yaml Adds the oVirt volume populator CRD.
charts/forklift-operator/templates/openstackvolumepopulator-crd.yaml Adds the OpenStack volume populator CRD.
charts/forklift-operator/templates/vspherexcopyvolumepopulator-crd.yaml Adds the vSphere xcopy volume populator CRD.
Comments suppressed due to low confidence (4)

charts/forklift-operator/templates/plan-crd.yaml:202

  • Typo in the CRD description: "leverl" should be "level" (this wording appears multiple times in this file).
                  Note:
                    - This template can be overridden at the individual VM level
                    - If not specified on VM level and on Plan leverl, default naming conventions will be used
                type: string

charts/forklift-operator/templates/plan-crd.yaml:78

  • Grammar in the CRD description is incorrect: "The following Vm's are lack of SHA-2 support" is ungrammatical and should be rephrased (e.g., "The following VMs lack SHA-2 support...").
                description: |-
                  InstallLegacyDrivers determines whether to install legacy windows drivers in the VM.
                  The following Vm's are lack of SHA-2 support and need legacy drivers:
                  Windows XP (all)

charts/forklift-operator/templates/plan-crd.yaml:313

  • Grammar in the CRD description: "require guest agent" should be "requires (a) guest agent" (appears twice in this list).
                    - .DiskIndex: initial volume index of the disk
                    - .WinDriveLetter: Windows drive letter (lower case, if applicable, e.g. "c", require guest agent)
                    - .RootDiskIndex: index of the root disk
                    - .Shared: true if the volume is shared by multiple VMs, false otherwise
                    - .FileName: name of the file in the source provider (vmWare only, require guest agent)

charts/forklift-operator/templates/migration-crd.yaml:389

  • Typo in the CRD description: "leverl" should be "level" (this wording appears multiple times in this file).
                        Note:
                          - This template will override at the plan level template
                          - If not specified on VM level and on Plan leverl, default naming conventions will be used
                      type: string

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ibrokethecloud ibrokethecloud force-pushed the forklift-v1.8.0-dev.0 branch from 51327ab to d988572 Compare March 9, 2026 23:06
Yu-Jack
Yu-Jack previously approved these changes Mar 9, 2026
@ibrokethecloud ibrokethecloud force-pushed the forklift-v1.8.0-dev.0 branch 3 times, most recently from 2fceab9 to 9078c47 Compare March 11, 2026 08:45
bk201
bk201 previously approved these changes Mar 12, 2026
Signed-off-by: Gaurav Mehta <gaurav.mehta@suse.com>

include feedback from chart review

Signed-off-by: Gaurav Mehta <gaurav.mehta@suse.com>

release forklift chart v1.8.0-dev.0

Signed-off-by: Gaurav Mehta <gaurav.mehta@suse.com>

patch forklift-operator chart to use rancher/nginx images for ci

add a new ct-install.yaml config to skip install of forklift-operator
chart

Signed-off-by: Gaurav Mehta <gaurav.mehta@suse.com>
@ibrokethecloud ibrokethecloud force-pushed the forklift-v1.8.0-dev.0 branch from 108a495 to 3637eeb Compare March 12, 2026 02:00
@ibrokethecloud ibrokethecloud merged commit a1dabc8 into harvester:release Mar 12, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants