chore: bump harvester-upgrade-manager to 1.8.0-rc5#509
Conversation
Signed-off-by: Zespre Chang <zespre.chang@suse.com>
There was a problem hiding this comment.
Pull request overview
Bumps the harvester-upgrade-manager Helm chart metadata and default manager image tag to align with the v1.8.0-rc5 release candidate.
Changes:
- Update
values.yamlto userancher/harvester-upgrade-toolkit:v1.8.0-rc5. - Update
Chart.yamlversionandappVersionto1.8.0-rc5/v1.8.0-rc5.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| charts/harvester-upgrade-manager/values.yaml | Bumps the default manager image tag to v1.8.0-rc5. |
| charts/harvester-upgrade-manager/Chart.yaml | Updates chart version and appVersion to rc5. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| image: | ||
| repository: rancher/harvester-upgrade-toolkit | ||
| tag: "v1.8.0-rc3" | ||
| tag: "v1.8.0-rc5" |
There was a problem hiding this comment.
This chart hard-codes the image tag in values.yaml, and the template renders it directly (templates/manager/manager.yaml:70). Most other charts in this repo default the image tag to .Chart.AppVersion (e.g., charts/harvester-load-balancer/templates/deployment.yaml:22), which avoids having to bump both Chart.yaml appVersion and values.yaml tag and prevents accidental mismatches. Consider updating the manager deployment template to default to .Chart.AppVersion when manager.image.tag is unset, and then either remove the explicit tag here or keep it only as an override.
| tag: "v1.8.0-rc5" |
Problem:
Solution:
Related Issue(s):
Test plan:
Additional documentation or context