Add condition to skip processing for externally managed VMIs#47
Open
mattmattox wants to merge 1 commit intoharvester:masterfrom
Open
Add condition to skip processing for externally managed VMIs#47mattmattox wants to merge 1 commit intoharvester:masterfrom
mattmattox wants to merge 1 commit intoharvester:masterfrom
Conversation
mattmattox
changed the title
w13915984028
approved these changes
Dec 18, 2024
Member
w13915984028
left a comment
w13915984028
left a comment
There was a problem hiding this comment.
LGTM, please confirm the question, thanks.
| return vmi, nil | ||
| } | ||
|
|
||
| // Skip processing if the external-managed-node label is present |
Member
There was a problem hiding this comment.
@mattmattox Thanks for your committing and sorry for the later review, as no one was assigned to review the PR.
The PR looks good, and I only have this question:
L88 has the check if creator := vmi.Labels[builder.LabelKeyVirtualMachineCreator]; creator != virtualmachine.VirtualMachineCreatorNodeDriver to skip the VM.
If you add external VMIs to the cluster, does the related VMI still happens to have LabelKeyVirtualMachineCreator label? could you utilize this existing label to skip it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to address harvester/harvester#6305
TLDR; It adds support for the label
harvesterhci.io/external-managed-node=trueto force the cloud provider to skip checking that node.