Dual stack node support / allow defining internal ranges as CIDR#50
Open
marnixbouhuis wants to merge 2 commits intoharvester:masterfrom
Open
Dual stack node support / allow defining internal ranges as CIDR#50marnixbouhuis wants to merge 2 commits intoharvester:masterfrom
marnixbouhuis wants to merge 2 commits intoharvester:masterfrom
Conversation
3a2856b to
5cb8f03
Compare
Author
|
Fixed the linter issue! 😀 |
Author
|
After some extra testing I found out that link local IPv6 addresses give issues when provisioning a new cluster, after this change everything provisions and the cluster becomes healthy: This cluster was deployed using the following helm chart config: |
Author
|
@starbops @FrankYang0529 @innobead is there something I can do to get this merged? Would be nice to have this in the official harvester cloud provider image instead of having to run my own version 😄. Let me know if I can do something! |
Member
|
@marnixbouhuis Thanks for your PR, we will review it recently. |
172f315 to
25be764
Compare
…al IPs as CIDR ranges. Signed-off-by: Marnix Bouhuis <marnix@bouhuis.com>
…trapping Signed-off-by: Marnix Bouhuis <marnix@bouhuis.com>
25be764 to
0aa4126
Compare
Author
|
Rebased the PR, new image with all new changes from master: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Currently it's not possible to use
cloud-provider-harvesterfor dualstack / ipv6 only clusters.This is because of a bug described here: harvester/harvester#7275
This PR fixes this bug and adds better network support.
List of changes:
192.168.1.1/24).