Add node driver known issues#292
Merged
guangbochen merged 1 commit intoharvester:mainfrom Mar 20, 2023
Merged
Conversation
✅ Deploy Preview for harvester-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
futuretea
force-pushed
the
node-driver-issues
branch
from
fda3893 to
78782db
Compare
guangbochen
reviewed
Mar 15, 2023
bk201
reviewed
Mar 15, 2023
vickyhella
reviewed
Mar 15, 2023
Contributor
vickyhella
left a comment
vickyhella
left a comment
There was a problem hiding this comment.
Just some small suggestions
vickyhella
reviewed
Mar 15, 2023
Signed-off-by: futuretea <Hang.Yu@suse.com> Co-authored-by: Guangbo <guangbo.chen@suse.com> Co-authored-by: vickyhella <vickyhella@hotmail.com>
futuretea
force-pushed
the
node-driver-issues
branch
from
b3d58d5 to
5ec387a
Compare
guangbochen
approved these changes
Mar 15, 2023
Contributor
There was a problem hiding this comment.
LGTM, and we can merge this PR after the issue is validated, thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
harvester/harvester#3272
rancher/rancher#40814