Skip to content

Instructions for checking status of new Volume snapshot and update Volume Snapshot page#302

Merged
LucasSaintarbor merged 20 commits intoharvester:mainfrom
LucasSaintarbor:2838-volume-snapshot-page-update
Jul 31, 2023
Merged

Instructions for checking status of new Volume snapshot and update Volume Snapshot page#302
LucasSaintarbor merged 20 commits intoharvester:mainfrom
LucasSaintarbor:2838-volume-snapshot-page-update

Conversation

@LucasSaintarbor
Copy link
Contributor

@LucasSaintarbor LucasSaintarbor commented Apr 18, 2023

Summary
Resolves #2838

Next steps

@netlify
Copy link

netlify bot commented Apr 18, 2023

Deploy Preview for harvester-preview ready!

Name Link
🔨 Latest commit a74d0e0
🔍 Latest deploy log https://app.netlify.com/sites/harvester-preview/deploys/64c7ef0d4917310008aeb969
😎 Deploy Preview https://deploy-preview-302--harvester-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@LucasSaintarbor LucasSaintarbor changed the title Added reference to (https://github.com/harvester/harvester/issues/2838#issuecomment-1314355041) and updated Volume Snapshot page Added instructions for accessing embedded Longhorn dashboard and updated Volume Snapshot page (2838) Apr 19, 2023
@LucasSaintarbor LucasSaintarbor changed the title Added instructions for accessing embedded Longhorn dashboard and updated Volume Snapshot page (2838) Add instructions for accessing embedded Longhorn dashboard and updated Volume Snapshot page (2838) Apr 19, 2023
@LucasSaintarbor LucasSaintarbor changed the title Add instructions for accessing embedded Longhorn dashboard and updated Volume Snapshot page (2838) (2838) Add instructions for accessing embedded Longhorn dashboard and updated Volume Snapshot page Apr 19, 2023
Copy link
Contributor

@vickyhella vickyhella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only some nits and the rest LGTM!

@LucasSaintarbor LucasSaintarbor removed the request for review from guangbochen May 17, 2023 19:15
Co-authored-by: vickyhella <vickyhella@hotmail.com>
@LucasSaintarbor
Copy link
Contributor Author

@futuretea may you review these instructions when you get the chance? Thanks!

@LucasSaintarbor LucasSaintarbor changed the title (2838) Add instructions for accessing embedded Longhorn dashboard and updated Volume Snapshot page Instructions for accessing embedded Longhorn dashboard and updated Volume Snapshot page Jun 27, 2023
@LucasSaintarbor LucasSaintarbor added this to the v1.2.0 milestone Jun 27, 2023
Copy link
Contributor Author

@LucasSaintarbor LucasSaintarbor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@futuretea removed instructions for accessing embedded Longhorn dashboard. Is it okay to merge?

@LucasSaintarbor LucasSaintarbor requested a review from futuretea July 6, 2023 21:15
Copy link
Contributor

@futuretea futuretea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. Just need to squash commits

@LucasSaintarbor
Copy link
Contributor Author

LGTM, thanks. Just need to squash commits

Thanks! Adding these updates to v1.1 as well.

@LucasSaintarbor LucasSaintarbor merged commit 7dff85b into harvester:main Jul 31, 2023
@LucasSaintarbor LucasSaintarbor deleted the 2838-volume-snapshot-page-update branch July 31, 2023 17:35
@LucasSaintarbor LucasSaintarbor changed the title Instructions for accessing embedded Longhorn dashboard and updated Volume Snapshot page Instructions for checking status of new Volume and update Volume Snapshot page Jul 31, 2023
@LucasSaintarbor LucasSaintarbor changed the title Instructions for checking status of new Volume and update Volume Snapshot page Instructions for checking status of new Volume snapshot and update Volume Snapshot page Jul 31, 2023
vickyhella added a commit to vickyhella/harvester-docs that referenced this pull request Sep 4, 2023
…lume Snapshot page (harvester#302)

* Added reference to (harvester/harvester#2838 (comment)) and updated Volume Snapshot page

* Added screenshots / revised content

* Add / update screenshots

* Small style changes. Added a new h3 for viewing replicaiton status / health status

* Add h3 to wrong section. Corrected mistake.

* Small update "...view the replication and health status for your new volume from Longhorn dashboard"

* Replaced "your" with "the"

* Apply suggestions from code review

Co-authored-by: vickyhella <vickyhella@hotmail.com>

* Update steps for creating volume snapshots

Add steps for viewing the status of volume snapshots, remove steps for viewing the status of VM snaptshots

* Remove replication and health status section

* Delete restore-volume-snapshot-5.png

* Delete restore-volume-snapshot-6.png

* Delete restore-volume-snapshot-7.png

* Update volume-snapshots.md

Updated per https://github.com/harvester/docs/pull/302/files#r1255511091

* Fix link to header > `restore-a-new-volume-from-a-volume-snapshot`

* Update v1.1 docs + small formatting changes

* Update image links for v1.1

---------

Co-authored-by: vickyhella <vickyhella@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Doc] Documentation missing: how to deal with volumes?

3 participants