Instructions for adding a container disk when creating a VM#303
Merged
bk201 merged 17 commits intoharvester:mainfrom Jun 28, 2023
Merged
Instructions for adding a container disk when creating a VM#303bk201 merged 17 commits intoharvester:mainfrom
bk201 merged 17 commits intoharvester:mainfrom
Conversation
✅ Deploy Preview for harvester-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
LucasSaintarbor
changed the title
…bor/harvester-docs into 3791-container-disk
…bor/harvester-docs into 3791-container-disk
LucasSaintarbor
changed the title
LucasSaintarbor
changed the title
vickyhella
reviewed
May 5, 2023
Contributor
vickyhella
left a comment
vickyhella
left a comment
There was a problem hiding this comment.
Just some small suggestions, the rest LGTM!
Co-authored-by: vickyhella <vickyhella@hotmail.com>
Co-authored-by: vickyhella <vickyhella@hotmail.com>
Co-authored-by: vickyhella <vickyhella@hotmail.com>
Co-authored-by: vickyhella <vickyhella@hotmail.com>
Contributor
Author
Thanks @vickyhella for reviewing! Added your suggestions |
vickyhella
approved these changes
May 9, 2023
Contributor
|
@LucasSaintarbor Please also update the v1.1 doc as mentioned in this PR's description, and then this PR is good to merge |
Contributor
Author
|
@bk201 May you review this update when you get the chance? Resolves: harvester/harvester#3791 |
bk201
reviewed
May 25, 2023
bk201
reviewed
May 25, 2023
Co-authored-by: Kiefer Chang <1691518+bk201@users.noreply.github.com>
Contributor
Author
|
@bk201 just want to confirm if this is okay to merge? Thanks! |
LucasSaintarbor
changed the title
Contributor
Sure, LGTM. Apologize for the delay. |
bk201
approved these changes
Jun 28, 2023
chrisho
pushed a commit
to chrisho/docs
that referenced
this pull request
Jul 19, 2023
…r#303) * Updated Create VM page. Added instructions to add container disk when creating a VM Co-authored-by: vickyhella <vickyhella@hotmail.com> Co-authored-by: Kiefer Chang <1691518+bk201@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves harvester/harvester#3791
Next steps
Questions