emphasis Product_UUID needs to be unique#324
Merged
guangbochen merged 1 commit intoharvester:mainfrom Jun 29, 2023
Merged
Conversation
✅ Deploy Preview for harvester-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
LucasSaintarbor
approved these changes
Jun 6, 2023
Contributor
LucasSaintarbor
left a comment
LucasSaintarbor
left a comment
There was a problem hiding this comment.
Small changes. LGTM 👍
LucasSaintarbor
approved these changes
Jun 6, 2023
Contributor
LucasSaintarbor
left a comment
LucasSaintarbor
left a comment
There was a problem hiding this comment.
Small changes. LGTM 👍
guangbochen
reviewed
Jun 27, 2023
Contributor
guangbochen
left a comment
guangbochen
left a comment
There was a problem hiding this comment.
The change is LGTM, can we also backport this to the v1.1 path, thanks.
Signed-off-by: Jian Wang <w13915984028@gmail.com>
Member
Author
@guangbochen v1.1 is also updated, thanks. |
guangbochen
approved these changes
Jun 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related issue:
harvester/harvester#4025