Skip to content

add image packaging doc#325

Merged
guangbochen merged 1 commit intoharvester:mainfrom
guangbochen:air-gap
Jun 28, 2023
Merged

add image packaging doc#325
guangbochen merged 1 commit intoharvester:mainfrom
guangbochen:air-gap

Conversation

@guangbochen
Copy link
Contributor

@guangbochen guangbochen commented Jun 5, 2023

@netlify
Copy link

netlify bot commented Jun 5, 2023

Deploy Preview for harvester-preview ready!

Name Link
🔨 Latest commit e4c5e00
🔍 Latest deploy log https://app.netlify.com/sites/harvester-preview/deploys/649934067654d50008f09c04
😎 Deploy Preview https://deploy-preview-325--harvester-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

docs/airgap.md Outdated

:::

## Image Packaging
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the section most addresses guest cluster images, how about naming the section "Guest Cluster Images"?

@LucasSaintarbor LucasSaintarbor added this to the v1.2.0 milestone Jun 7, 2023
Co-authored-by: Lucas Saintarbor <lucas.saintarbor@suse.com>
Copy link
Contributor

@bk201 bk201 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guangbochen guangbochen merged commit 2fa73fc into harvester:main Jun 28, 2023
@guangbochen
Copy link
Contributor Author

@LucasSaintarbor I have merged the PR since you have already reviewed it, feel free to leave a comment if u see any problems, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants